Unwinding failure with Node v24.11.1 (current LTS, both amd64 and arm64)

[christos68k]

Summary

I've noticed this after executing some test workloads for an unrelated issue. I also tested the following Node versions where unwinding works (both arm64 and amd64):

1. v20.19.1
2. v22.21.1
3. v23.11.1

To reproduce

$ nvm install v24.11.1
$ node --version
v24.11.1
$ node hello3.js

hello3.js

function bar(a, s) {
	a(s)
	//ads
}

function foo() {
	bar(a, "Hello world!")
}

console.trace("I am here");
a = console.log
while (1) {
	foo()
}

Expected output

Actual output

[christos68k]

@gnurizen Maybe Polar Signals have a fix (IIRC you've previously contributed ARM64 Node.JS support) that you'd like to contribute?

[brancz]

I think @umanwizard you fixed this already, no?

[brancz]

I want to say parca-dev#172 was part of what we fixed, anything else @umanwizard ?

[gnurizen]

@christos68k sorry for missing this! Gotta get my GH notifications dialed in...

[umanwizard]

Yes, that is the main recent thing. I will put up a PR soon and then we can see if that fixes your issue. Feel free to assign this to me.

[umanwizard]

I just checked, and we're also failing to unwind this code in Parca/Polar Signals in the latest v24 (but the latest v23 works fine). So, unfortunately I don't think the patch mentioned above fixes things, and I will need to look into this more deeply.

[umanwizard]

On the Parca side, this is caused by the Node commit c67cb727cb1d67d4c30c7cd745a787bdf060f834 (build: build v8 with -fvisibility=hidden -fvisibility-inlines-hidden)

In the v24 series, this commit was first backported in v24.11.1.

I suspect (though haven't verified this theory yet) that it is stopping us from reading the introspection data, and we will have to get the offsets in another way.

[umanwizard]

This PR: parca-dev#188 fixes the issue in parca-agent.

Our fork has diverged some from upstream with respect to the symbol-reading APIs, so I'll need to rework it a bit in order to land upstream.

[christos68k]

Fixed by #1067