Skip to content

Commit 5b56d30

Browse files
dalehamelflorianl
andauthored
Apply suggestions from code review
Co-authored-by: Florian Lehner <florianl@users.noreply.github.com>
1 parent 3b0f653 commit 5b56d30

2 files changed

Lines changed: 6 additions & 3 deletions

File tree

interpreter/ruby/ruby.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -69,6 +69,7 @@ const (
6969
rarrayEmbed = RUBY_FL_USER1
7070

7171
// PATHOBJ_REALPATH
72+
// https://github.com/ruby/ruby/blob/3185786874315ab4f1cfcc73c3d1b14613452905/vm_core.h#L343
7273
pathObjRealPathIdx = 1
7374

7475
// ISEQ_TYPE_METHOD
@@ -94,7 +95,7 @@ var (
9495
// regex to extract a version from a string
9596
rubyVersionRegex = regexp.MustCompile(`^(\d)\.(\d)\.(\d)$`)
9697

97-
unknownCfunc = libpf.Intern("<unknown ruby cfunc>")
98+
unknownCfunc = libpf.Intern("<unknown cfunc>")
9899
cfuncDummyFile = libpf.Intern("<cfunc>")
99100
// compiler check to make sure the needed interfaces are satisfied
100101
_ interpreter.Data = &rubyData{}

metrics/metrics.json

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1765,14 +1765,16 @@
17651765
"id": 243
17661766
},
17671767
{
1768-
"description": "Number of failures to read the instruction sequence encoded size (deprecated)",
1768+
"description": "Number of failures to read the instruction sequence encoded size",
1769+
"obsolete": true,
17691770
"type": "counter",
17701771
"name": "UnwindRubyErrReadIseqEncoded",
17711772
"field": "bpf.ruby.errors.read_iseq_encoded",
17721773
"id": 244
17731774
},
17741775
{
1775-
"description": "Number of failures to read the instruction sequence size (deprecated)",
1776+
"description": "Number of failures to read the instruction sequence size",
1777+
"obsolete": true,
17761778
"type": "counter",
17771779
"name": "UnwindRubyErrReadIseqSize",
17781780
"field": "bpf.ruby.errors.read_iseq_size",

0 commit comments

Comments
 (0)