From 05ade5fef22a0443858163ef7ffa8b82f46c7261 Mon Sep 17 00:00:00 2001 From: Douglas Barker Date: Fri, 13 Mar 2026 12:23:56 -0400 Subject: [PATCH] fix clang-tidy performance-for-range-copy warnings --- .../include/opentelemetry/exporters/ostream/common_utils.h | 4 ++-- sdk/include/opentelemetry/sdk/common/attributemap_hash.h | 2 +- .../sdk/instrumentationscope/scope_configurator.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/exporters/ostream/include/opentelemetry/exporters/ostream/common_utils.h b/exporters/ostream/include/opentelemetry/exporters/ostream/common_utils.h index ec860794f0..e6335f0c12 100644 --- a/exporters/ostream/include/opentelemetry/exporters/ostream/common_utils.h +++ b/exporters/ostream/include/opentelemetry/exporters/ostream/common_utils.h @@ -31,7 +31,7 @@ void print_value(const std::vector &vec, std::ostream &sout) sout << '['; size_t i = 1; size_t sz = vec.size(); - for (auto v : vec) + for (const auto &v : vec) { sout << v; if (i != sz) @@ -47,7 +47,7 @@ void print_value(const nostd::span &vec, std::ostream &sout) sout << '['; size_t i = 1; size_t sz = vec.size(); - for (auto v : vec) + for (const auto &v : vec) { sout << v; if (i != sz) diff --git a/sdk/include/opentelemetry/sdk/common/attributemap_hash.h b/sdk/include/opentelemetry/sdk/common/attributemap_hash.h index e56d6aaf75..5ab30e7f5f 100644 --- a/sdk/include/opentelemetry/sdk/common/attributemap_hash.h +++ b/sdk/include/opentelemetry/sdk/common/attributemap_hash.h @@ -32,7 +32,7 @@ inline void GetHash(size_t &seed, const T &arg) template inline void GetHash(size_t &seed, const std::vector &arg) { - for (auto v : arg) + for (const auto &v : arg) { GetHash(seed, v); } diff --git a/sdk/include/opentelemetry/sdk/instrumentationscope/scope_configurator.h b/sdk/include/opentelemetry/sdk/instrumentationscope/scope_configurator.h index f2d046f53a..71bc61b6a3 100644 --- a/sdk/include/opentelemetry/sdk/instrumentationscope/scope_configurator.h +++ b/sdk/include/opentelemetry/sdk/instrumentationscope/scope_configurator.h @@ -89,7 +89,7 @@ class ScopeConfigurator return ScopeConfigurator( [conditions_ = this->conditions_, default_scope_config_ = this->default_scope_config_]( const InstrumentationScope &scope_info) { - for (Condition condition : conditions_) + for (const Condition &condition : conditions_) { if (condition.scope_matcher(scope_info)) {