simplify tests

Author: LDiazN

oonipipeline/tests/test_time_inconsistencies.py

@@ -22,7 +22,7 @@ def test_time_inconsistencies_basic(db, fastpath, fastpath_data_time_inconsisten
     )
 
     result = db.execute(
-        "SELECT ts, type, probe_cc, probe_asn, details FROM faulty_measurements WHERE type IN ('time_inconsistency_future', 'time_inconsistency_past')"
+        "SELECT ts, type, probe_cc, probe_asn, details FROM faulty_measurements WHERE type LIKE 'time_inconsistency%'"
     )
     assert len(result) > 0, "Missing time inconsistency anomalies"
 
@@ -64,7 +64,7 @@ def test_time_inconsistencies_no_anomalies(
     )
 
     # No anomalies expected
-    result = db.execute("SELECT type FROM faulty_measurements WHERE type IN ('time_inconsistency_future', 'time_inconsistency_past')")
+    result = db.execute("SELECT type FROM faulty_measurements WHERE type LIKE 'time_inconsistency%'")
     assert len(result) == 0, f"Unexpected anomalies: {len(result)} = {result}"
 
 
@@ -86,7 +86,7 @@ def test_time_inconsistencies_time_range_filtering(
     )
 
     # No events expected
-    results = db.execute("SELECT type FROM faulty_measurements WHERE type IN ('time_inconsistency_future', 'time_inconsistency_past')")
+    results = db.execute("SELECT type FROM faulty_measurements WHERE type LIKE 'time_inconsistency%'")
     assert len(results) == 0, f"Too many results: {len(results)} - {results}"
 
 
@@ -108,7 +108,7 @@ def test_time_inconsistencies_threshold_boundary(
     )
 
     result = db.execute(
-        "SELECT ts, type, probe_cc, probe_asn, details FROM faulty_measurements WHERE type IN ('time_inconsistency_future', 'time_inconsistency_past')"
+        "SELECT ts, type, probe_cc, probe_asn, details FROM faulty_measurements WHERE type LIKE 'time_inconsistency%'"
     )
     assert len(result) > 0, "Expected time inconsistency anomalies"
 
@@ -119,3 +119,45 @@ def test_time_inconsistencies_threshold_boundary(
             assert abs(details["diff_seconds"]) >= future_threshold, f"invalid threshold: {details['diff_seconds']}"
         else:
             assert details["diff_seconds"] >= past_threshold, f"invalid threshold: {details['diff_seconds']}"
+
+
+def test_time_inconsistencies_future_and_past(
+    db, fastpath, fastpath_data_time_inconsistencies, clean_faulty_measurements
+):
+    """
+    Test that we detect both future and past time inconsistencies.
+    """
+    future_threshold = 3600  # 1 hour
+    past_threshold = 3600  # 1 hour
+
+    time_inconsistencies.run_time_inconsistencies_analysis(
+        clickhouse_url=db.clickhouse_url,
+        start_time=START_TIME,
+        end_time=END_TIME,
+        future_threshold=future_threshold,
+        past_threshold=past_threshold,
+    )
+
+    result = db.execute(
+        "SELECT ts, type, probe_cc, probe_asn, details FROM faulty_measurements WHERE type LIKE 'time_inconsistency%'"
+    )
+
+    future_anomalies = [row for row in result if row[1] == "time_inconsistency_future"]
+    past_anomalies = [row for row in result if row[1] == "time_inconsistency_past"]
+
+    assert len(future_anomalies) > 0, "Should have at least one future anomaly"
+    assert len(past_anomalies) > 0, "Should have  at least one past  anomaly"
+
+    # future anomalies should have negative diff_seconds
+    for row in future_anomalies:
+        _, _, _, _, details_str = row
+        details = orjson.loads(details_str)
+        assert details["diff_seconds"] < 0, f"Unexpected diff_seconds: {details['diff_seconds']}"
+        assert abs(details["diff_seconds"]) >= future_threshold
+
+    # past anomalies should have positive diff_seconds
+    for row in past_anomalies:
+        _, _, _, _, details_str = row
+        details = orjson.loads(details_str)
+        assert details["diff_seconds"] > 0, f"Unexpected diff_seconds: {details['diff_seconds']}"
+        assert details["diff_seconds"] >= past_threshold