Skip to content

Commit 3cecc43

Browse files
committed
[CLN] estate: address PR comments
1 parent d802e95 commit 3cecc43

8 files changed

Lines changed: 9 additions & 13 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -127,3 +127,4 @@ dmypy.json
127127

128128
# Pyre type checker
129129
.pyre/
130+
.vscode/

.vscode/settings.json

Lines changed: 0 additions & 3 deletions
This file was deleted.

estate/__manifest__.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,10 +3,9 @@
33
'author': "Odoo",
44
'website': "https://www.odoo.com/",
55
'category': 'Tutorials',
6-
'version': '0.1',
76
'application': True,
87
'installable': True,
9-
'depends': ['base', 'web'],
8+
'depends': ['base'],
109
'data': [
1110
'security/ir.model.access.csv',
1211
'views/estate_property_views.xml',
@@ -15,6 +14,5 @@
1514
'views/estate_property_offers_views.xml',
1615
'views/estate_menus.xml',
1716
],
18-
'assets': {},
1917
'license': 'AGPL-3'
2018
}

estate/models/estate_property.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44

55

66
class EstateProperty(models.Model):
7-
_name = "estate.property"
8-
_description = "Estate Property Model"
7+
_name = 'estate.property'
8+
_description = "Estate Property"
99

1010
name = fields.Char(required=True)
1111
description = fields.Text(string="Description")

estate/models/estate_property_type.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33

44
class EstatePropertyType(models.Model):
5-
_name = "estate.property.type"
5+
_name = 'estate.property.type'
66
_description = "Property Type"
77

8-
name = fields.Char('Property Type', required=True)
8+
name = fields.Char("Property Type", required=True)

estate/security/ir.model.access.csv

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,4 +2,4 @@ id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
22
estate.access_estate_property,access_estate_property,estate.model_estate_property,base.group_user,1,1,1,1
33
estate.access_estate_property_type,access_estate_property_type,estate.model_estate_property_type,base.group_user,1,1,1,1
44
estate.access_estate_property_tag,access_estate_property_tag,estate.model_estate_property_tag,base.group_user,1,1,1,1
5-
estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1
5+
estate.access_estate_property_offer,access_estate_property_offer,estate.model_estate_property_offer,base.group_user,1,1,1,1

estate/views/estate_property_offers_views.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,4 +33,4 @@
3333
</field>
3434
</record>
3535

36-
</odoo>
36+
</odoo>

estate/views/estate_property_tags_views.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,4 @@
77
<field name="view_mode">list,form</field>
88
</record>
99

10-
</odoo>
10+
</odoo>

0 commit comments

Comments
 (0)