Skip to content

Commit be39cdb

Browse files
Copilothotlong
andcommitted
fix: address code review feedback
- Remove void workaround in MemoryQueueAdapter, use underscore prefix - Remove void workaround in RedisCacheAdapter - Fix ROADMAP.md count inconsistency (15→12 spec-only contracts) Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
1 parent f51ac47 commit be39cdb

3 files changed

Lines changed: 3 additions & 5 deletions

File tree

ROADMAP.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ the ecosystem for enterprise workloads.
6161

6262
### What Needs Building
6363

64-
15 of 25 service contracts are specification-only (no runtime implementation).
64+
12 of 25 service contracts are specification-only (no runtime implementation).
6565
These are the backbone of ObjectStack's enterprise capabilities.
6666

6767
---

packages/services/service-cache/src/redis-cache-adapter.ts

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,6 @@ export class RedisCacheAdapter implements ICacheService {
4242
}
4343

4444
async set<T = unknown>(_key: string, _value: T, _ttl?: number): Promise<void> {
45-
void this.defaultTtl;
4645
throw new Error('RedisCacheAdapter not yet implemented');
4746
}
4847

packages/services/service-queue/src/memory-queue-adapter.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -71,9 +71,8 @@ export class MemoryQueueAdapter implements IQueueService {
7171
this.handlers.delete(queue);
7272
}
7373

74-
async getQueueSize(queue: string): Promise<number> {
75-
// In-memory: no persistent queue, count dead letters for the queue
76-
void queue;
74+
async getQueueSize(_queue: string): Promise<number> {
75+
// In-memory: no persistent queue depth tracking
7776
return 0;
7877
}
7978

0 commit comments

Comments
 (0)