Skip to content

OpenAPI: /request-credential description mentions session_id but schema doesn't return it #4230

@reinkrul

Description

@reinkrul

Problem

The POST /internal/auth/v2/{subjectID}/request-credential endpoint in docs/_static/auth/v2.yaml has a misleading response description.

The description on the 200 response says:

Successful request. Responds with a redirect_uri for the user and a session_id for correlation.

However, the schema referenced by that response is RedirectResponse, which only contains redirect_uri — no session_id. The session_id field belongs to RedirectResponseWithID, used by other endpoints (e.g. request-user-access-token).

See:

  • Description: docs/_static/auth/v2.yaml around line 188-189
  • RedirectResponse schema: docs/_static/auth/v2.yaml:552
  • RedirectResponseWithID schema: docs/_static/auth/v2.yaml:562

Fix options

Either:

  1. Update the description to drop the session_id mention (if no correlation ID is actually needed for this flow), or
  2. Change the response schema to RedirectResponseWithID and have the implementation return a session_id (if correlation is intended).

Option 1 matches current behavior; option 2 would be a behavioral change.

Assisted by AI

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions