Fast-path UserData member access via ILuaUserData.TryIndex. #234#316
Open
ModMaker101 wants to merge 1 commit into
Open
Fast-path UserData member access via ILuaUserData.TryIndex. #234#316ModMaker101 wants to merge 1 commit into
ModMaker101 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add a
TryIndexfast path toILuaUserDatathat bypasses the metatable chain for known member lookups. Overall reducing overhead for proerty and method access onUserdatatypes.Changes
TryIndextoILuaUserData.TryIndexinto all four VM slow-path methods.[LuaObject]source gens.TryIndexonFileHandlefor less overhead method dispatch.Results
Before with the DoString benchmark (on my computer) I got a result of 10.56 ms, after my update it went down to 9.16 ms, or a +13.2% gain. Likewise, with DoFileAsync, I got a result of 9.627 ms, afterwards 9.22, or a gain of +4.2%. Now granted this speedup is on smaller functions, if this speedup was applied on heavier workloads, it would most likely perform much better.
All 267 tests pass. Ready for review
Related