fix(arborist): retry bin-links on Windows EPERM during linked strategy install

On Windows, antivirus and search indexer can transiently lock files,
causing write-file-atomic's fs.rename to fail with EPERM during the
bin-linking phase. The linked strategy amplifies this by writing many
store entries in parallel.

Add retry with backoff (up to 5 attempts) for EPERM/EACCES/EBUSY
errors in #createBinLinks, Windows only.

Author: manzoorwanijk

workspaces/arborist/lib/arborist/rebuild.js

@@ -381,18 +381,36 @@ module.exports = cls => class Builder extends cls {
 
     const timeEnd = time.start(`build:link:${node.location}`)
 
-    const p = binLinks({
-      pkg: node.package,
-      path: node.path,
-      top: !!(node.isTop || node.globalTop),
-      force: this.options.force,
-      global: !!node.globalTop,
-    })
+    const p = this.#binLinksWithRetry(node)
 
     await (this.#doHandleOptionalFailure
       ? this[_handleOptionalFailure](node, p)
       : p)
 
     timeEnd()
   }
+
+  // On Windows, antivirus/indexer can transiently lock files, causing
+  // EPERM/EACCES/EBUSY on the rename inside write-file-atomic (used by
+  // bin-links/fix-bin.js).  Retry with backoff for up to 10 seconds.
+  async #binLinksWithRetry (node, retries = 5) {
+    try {
+      return await binLinks({
+        pkg: node.package,
+        path: node.path,
+        top: !!(node.isTop || node.globalTop),
+        force: this.options.force,
+        global: !!node.globalTop,
+      })
+    } catch (err) {
+      if (process.platform === 'win32' &&
+          retries > 0 &&
+          (err.code === 'EPERM' || err.code === 'EACCES' || err.code === 'EBUSY')) {
+        const delay = (6 - retries) * 500
+        await new Promise(r => setTimeout(r, delay))
+        return this.#binLinksWithRetry(node, retries - 1)
+      }
+      throw err
+    }
+  }
 }