stream: preserve error over AbortError in pipeline

Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
PR-URL: #62113
Fixes: #62089
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Author: marcopiraccini

lib/internal/streams/pipeline.js

@@ -227,7 +227,7 @@ function pipelineImpl(streams, callback, opts) {
   }
 
   function finishImpl(err, final) {
-    if (err && (!error || error.code === 'ERR_STREAM_PREMATURE_CLOSE')) {
+    if (err && (!error || error.code === 'ERR_STREAM_PREMATURE_CLOSE' || error.name === 'AbortError')) {
       error = err;
     }
 

test/parallel/test-stream-pipeline.js

@@ -1749,3 +1749,24 @@ tmpdir.refresh();
     assert.deepStrictEqual(err, new Error('booom'));
   }));
 }
+
+{
+  // Errors thrown in Readable.map inside pipeline should not be
+  // swallowed by AbortError when the source is an infinite stream.
+  pipeline(
+    new Readable({ read() { this.push('data'); } }),
+    new Transform({
+      readableObjectMode: true,
+      transform(chunk, encoding, callback) {
+        this.push({});
+        callback();
+      },
+    }),
+    (readable) => readable.map(async () => {
+      throw new Error('Boom!');
+    }),
+    common.mustCall((err) => {
+      assert.strictEqual(err.message, 'Boom!');
+    }),
+  );
+}