use skipTest()

Signed-off-by: Balakrishna Avulapati <ba@bavulapati.com>

Author: bavulapati

eslint.config.js

@@ -17,6 +17,8 @@ export default defineConfig([
         mustNotCall: "readonly",
         gcUntil: "readonly",
         experimentalFeatures: "readonly",
+        napiVersion: "readonly",
+        skipTest: "readonly",
       },
     },
     rules: {

implementors/node/process.js

@@ -0,0 +1,7 @@
+const napiVersion = Number(process.versions.napi);
+
+const skipTest = () => {
+  process.exit(0);
+};
+
+Object.assign(globalThis, { napiVersion, skipTest });

implementors/node/tests.ts

@@ -34,6 +34,12 @@ const GC_MODULE_PATH = path.join(
   "node",
   "gc.js"
 );
+const PROCESS_MODULE_PATH = path.join(
+  ROOT_PATH,
+  "implementors",
+  "node",
+  "process.js"
+);
 const MUST_CALL_MODULE_PATH = path.join(
   ROOT_PATH,
   "implementors",
@@ -79,6 +85,8 @@ export function runFileInSubprocess(
         "--import",
         "file://" + GC_MODULE_PATH,
         "--import",
+        "file://" + PROCESS_MODULE_PATH,
+        "--import",
         "file://" + MUST_CALL_MODULE_PATH,
         filePath,
       ],

tests/js-native-api/test_dataview/test.js

@@ -1,48 +1,52 @@
 "use strict";
 
-if (experimentalFeatures.sharedArrayBuffer) {
-  // Testing api calls for arrays
-  const test_dataview = loadAddon("test_dataview");
-
-  // Test for creating dataview with ArrayBuffer
-  {
-    const buffer = new ArrayBuffer(128);
-    const template = Reflect.construct(DataView, [buffer]);
-
-    const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
-    assert.ok(
-      theDataview instanceof DataView,
-      `Expect ${theDataview} to be a DataView`,
-    );
-  }
-
-  // Test for creating dataview with SharedArrayBuffer
-  {
-    const buffer = new SharedArrayBuffer(128);
-    const template = new DataView(buffer);
-
-    const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
-    assert.ok(
-      theDataview instanceof DataView,
-      `Expect ${theDataview} to be a DataView`,
-    );
-
-    assert.strictEqual(template.buffer, theDataview.buffer);
-  }
-
-  // Test for creating dataview with ArrayBuffer and invalid range
-  {
-    const buffer = new ArrayBuffer(128);
-    assert.throws(() => {
-      test_dataview.CreateDataView(buffer, 10, 200);
-    }, RangeError);
-  }
-
-  // Test for creating dataview with SharedArrayBuffer and invalid range
-  {
-    const buffer = new SharedArrayBuffer(128);
-    assert.throws(() => {
-      test_dataview.CreateDataView(buffer, 10, 200);
-    }, RangeError);
-  }
+// The addon links node_api_is_sharedarraybuffer, which is only available
+// when the sharedArrayBuffer experimental feature is supported.
+if (!experimentalFeatures.sharedArrayBuffer) {
+  skipTest();
+}
+
+// Testing api calls for arrays
+const test_dataview = loadAddon("test_dataview");
+
+// Test for creating dataview with ArrayBuffer
+{
+  const buffer = new ArrayBuffer(128);
+  const template = Reflect.construct(DataView, [buffer]);
+
+  const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
+  assert.ok(
+    theDataview instanceof DataView,
+    `Expect ${theDataview} to be a DataView`,
+  );
+}
+
+// Test for creating dataview with SharedArrayBuffer
+{
+  const buffer = new SharedArrayBuffer(128);
+  const template = new DataView(buffer);
+
+  const theDataview = test_dataview.CreateDataViewFromJSDataView(template);
+  assert.ok(
+    theDataview instanceof DataView,
+    `Expect ${theDataview} to be a DataView`,
+  );
+
+  assert.strictEqual(template.buffer, theDataview.buffer);
+}
+
+// Test for creating dataview with ArrayBuffer and invalid range
+{
+  const buffer = new ArrayBuffer(128);
+  assert.throws(() => {
+    test_dataview.CreateDataView(buffer, 10, 200);
+  }, RangeError);
+}
+
+// Test for creating dataview with SharedArrayBuffer and invalid range
+{
+  const buffer = new SharedArrayBuffer(128);
+  assert.throws(() => {
+    test_dataview.CreateDataView(buffer, 10, 200);
+  }, RangeError);
 }