`test-rackspace-ubuntu2404-x64-2` fails citgm-smoker due to `rm` parameters

[sxa]

From https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu2404-x64/3761/consoleFull

09:40:12 + find /home/iojs/tmp -mtime +3
09:40:12 + xargs rm -rf
09:40:12 rm: unrecognized option '--include-dotfiles'
09:40:12 Try 'rm --help' for more information.
09:40:13 rm: unrecognized option '--include-dotfiles'
09:40:13 Try 'rm --help' for more information.
09:40:13 Build step 'Conditional steps (multiple)' marked build as failure

The same error does not occur on the other rackspace machine -1 (ref: https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu2404-x64/3762/consoleFull) which should be the same Ubuntu version, so something is including a parameter to rm which the second rackspace machine is objecting to. Leaving the machine offline for now until this is debugged.

[richardlau]

This might be due to some weird filenames from the modules and how those get piped to xargs rm -rf?

iojs@test-rackspace-ubuntu2404-x64-2:~$ find /home/iojs/tmp -mtime +3 | grep '\-\-include-dotfiles'
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/.babelrc
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/stdout.txt
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib/.foorc
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib/index.js
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib/foo
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib/foo/index.js
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib/foo/.foo.js
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/out-files/lib/README.md
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files/src
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files/src/.foorc
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files/src/index.js
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files/src/foo
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files/src/foo/index.js
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files/src/foo/.foo.js
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/in-files/src/README.md
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles with ignore in babelrc/options.json
/home/iojs/tmp/citgm_tmp/fb222521/@babel/core/packages/babel-cli/test/fixtures/babel/--copy-files --include-dotfiles
...

[richardlau]

In the job config we have this:

find "$NODE_TEST_DIR" -mtime +3 | xargs rm -rf
temp="$NODE_TEST_DIR"/citgm_tmp
rm -rf $temp/* || true
mkdir $temp || true

I'm not entirely sure why we're selectively removing files under NODE_TEST_DIR, but since we remove all of "$NODE_TEST_DIR"/citgm_tmp maybe a simple solution would be to move the first line after the rm -rf $temp/* || true line, which should remove those oddly named directories above under babel test fixtures?

[richardlau]

I've moved the line and testing https://ci.nodejs.org/job/citgm-smoker/nodes=ubuntu2404-x64/3763/ which is running on the affected machine.

[sxa]

rm -rf $temp/* || true

This line makes me nervous - while it's unlikely to happen when it's set in the previous line having something that could evaluate to rm -rf /* if a variable gets lost is not ideal. rm -rf "$temp" would be much better.
Also -f on rm removes the need for ||true

But then there's probably a bit of an overhaul needed on our inline scripts similar to what we've been discussing about iojs+release...

But thanks for looking into it - your fix seems to have allowed it to start running through ok so we can compare the results with the earlier job from rackspace-1 once it's done - I expect it'll be ok :-)

[richardlau]

The nuance being that rm -rf $temp/* removes everything under $temp but leaves $temp itself, whereas rm -rf $temp would remove $temp. But then we go and mkdir $temp afterwards anyway. I agree we should probably just rm -rf "$temp".

[richardlau]

Updated the job so it now does:

temp="$NODE_TEST_DIR"/citgm_tmp
rm -rf "$temp"
find "$NODE_TEST_DIR" -mtime +3 | xargs rm -rf
mkdir $temp

(compare to previous version in #4427 (comment))