Incompatibility with configuration cache when download=true

[marcphilipp]

When configuring node.download = true, the NodeSetupTask is incompatible with Gradle's configuration cache.

[deepy]

Hmm, I'm not able to reproduce it with the latest versions of gradle and the plugin, at least not on macOS. And all the tests should be running with configuration-cache enabled already to catch things like this

Is this on Windows?

[marcphilipp]

I'm using Gradle 9.7.0-rc-1 on Linux

[marcphilipp]

Here's a build scan: https://develocity.junit.org/s/opgbhru22nahg

[deepy]

Thanks! In hindsight the actual usage is pretty easy to spot:

gradle-node-plugin/src/main/kotlin/com/github/gradle/node/NodePlugin.kt

Lines 210 to 217 in ae31424

	project.tasks.withType<NodeSetupTask>().configureEach {
	nodeDir.set(nodeExtension.resolvedNodeDir)
	val archiveFileProvider = computeNodeArchiveDependency(nodeExtension)
	.map { nodeArchiveDependency ->
	resolveNodeArchiveFile(nodeArchiveDependency)
	}
	nodeArchiveFile.set(project.layout.file(archiveFileProvider))
	}

But weirdly enough, I can't reproduce it without this:
https://github.com/junit-team/junit-framework/blob/321a7a877fced6b82fd06cde519c405b94c1c3c8/gradle/plugins/antora/src/main/kotlin/junitbuild.antora-conventions.gradle.kts#L52-L54
And it's not just any provider either, without the providers.fileContents everything works fine 🤔

It does feel like there's potentially a bug or two in Gradle itself related to this, but now that I have a way of reproducing it I can fix and verify the issue in the plugin 🎉

[marcphilipp]

Thanks for looking into it! 👍