Renamed NGSession.shouldTerminate() to .shouldReap()

Author: hugithordarson

ng-appserver/src/main/java/ng/appserver/NGApplication.java

@@ -439,7 +439,7 @@ private void addSessionCookieToResponse( final NGRequest request, final NGRespon
 			final NGSession session = request.existingSession();
 
 			if( session != null ) {
-				if( session.shouldTerminate() ) {
+				if( session.shouldReap() ) {
 					// If the session is terminating, delete the client side session cookie
 					response.addCookie( createSessionResetCookie() );
 					// CHECKME: This might be a better location to ask session storage to dispose of a terminated session.
@@ -457,7 +457,7 @@ private void addSessionCookieToResponse( final NGRequest request, final NGRespon
 	private void touchSessionIfPresentAndNotTerminating( final NGRequest request ) {
 		final NGSession session = request.existingSession();
 
-		if( session != null && !session.shouldTerminate() ) {
+		if( session != null && !session.shouldReap() ) {
 			session.touch();
 		}
 	}

ng-appserver/src/main/java/ng/appserver/NGServerSessionStore.java

@@ -35,7 +35,7 @@ public void run() {
 
 				// CHECKME: Iterating through every session every five seconds itsn't exactly efficient. We might want to look into some alternative methods // Hugi 2023-01-21
 				for( final NGSession session : sessions() ) {
-					if( session.shouldTerminate() ) {
+					if( session.shouldReap() ) {
 						_sessions.remove( session.sessionID() );
 						logger.debug( "Terminated session with ID {}", session.sessionID() );
 					}

ng-appserver/src/main/java/ng/appserver/NGSession.java

@@ -122,7 +122,7 @@ private boolean isTimedOut() {
 	/**
 	 * @return true if this session should be harvested/terminated by session storage. This essentially means the session has timed out, or has been manually terminated
 	 */
-	public boolean shouldTerminate() {
+	public boolean shouldReap() {
 		return _manuallyTerminated || isTimedOut();
 	}