Skip to content

Link options: preview/text options visible for inline links #8331

@mejo-

Description

@mejo-

Describe the bug
The options to toggle a link between preview and text type is visible for links even if they're inline links, i.e. not alone in an otherwise empty paragraph. Trying to change such a link to preview doesn't do anything though.

To Reproduce
Steps to reproduce the behavior:

  1. Create a link surrounded by other text
  2. Click on the link, open the three-dot menu in the link bubble
  3. See the preview options
  4. Select "Show link preview", nothing happens

Expected behavior
I'm unsure what's the best fix:

  1. Remove the preview options from the three-dot menu when the link is inline. This means inconsistent UI for inline and stand-alone links
  2. Allow to transform inline links into a preview, which will split the paragraph and insert the preview as a new block node. This might be unexpected as well, but people always can undo this change.

I tend to prefer the second option.

@marcoambrosini @max-nextcloud what do you think?

Screenshots
Image

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions