Incorrect (extra) route for "save as" (WOPI `PutRelativeFile` / `PUT_RELATIVE`) file operation?

[joshtrichards]

Should't PutRelativeFile / PUT_RELATIVE¹ handling be via /wopi*/files/<fileId>? It's not supposed to be handled via the same route as PutFile / PUT² from what I can tell:

richdocuments/lib/Controller/WopiController.php

Lines 557 to 564 in 0bf027a

	#[FrontpageRoute(verb: 'POST', url: 'wopi/files/{fileId}/contents')]
	public function putFile(
	string $fileId,
	#[\SensitiveParameter]
	string $access_token,
	): JSONResponse {
	[$fileId, , ] = Helper::parseFileId($fileId);
	$isPutRelative = ($this->request->getHeader('X-WOPI-Override') === 'PUT_RELATIVE');

https://sdk.collaboraonline.com/docs/How_to_integrate.html#connection-to-the-file-storage

Footnotes

1. https://learn.microsoft.com/en-us/openspecs/office_protocols/ms-wopi/d12ab554-eab7-480f-bdc7-0bdf14922e6f ↩

2. https://learn.microsoft.com/en-us/openspecs/office_protocols/ms-wopi/42d0e5ae-074f-4d11-9d9b-706d843fad9c ↩

[joshtrichards]

Confirmed:

https://github.com/CollaboraOnline/online/blob/05963ac0a8f0d2dc39eccac1fcc67aa63a2cb111/wsd/wopi/WopiStorage.cpp#L750-L751

[joshtrichards]

Oh, I see how it works today - we have duplicate code paths. There is an explicit PutRelativeFile code path in the incorrect route handler (WopiController::putFile()) and there is a less explicit code path in the correct route handler (WopiController::postFile()). Both ultimately could handle a PutRelativeFile WOPI override with an X-Wopi-SuggestedTarget header.

The former path is effectively dead code I suspect.