From 45240e5d1be36967772b5688410849a536971307 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sim=C3=B3=20Albert=20i=20Beltran?= Date: Thu, 23 Jul 2026 20:27:15 +0200 Subject: [PATCH 1/2] fix: remove text "label" on top of favourite edit categories dropdown MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove the inputLabel prop from NcSelect in FavoriteEditionForm.vue that was rendering the string 'label' as visible text above the categories dropdown when editing a favourite. Signed-off-by: Simó Albert i Beltran --- src/components/FavoriteEditionForm.vue | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/FavoriteEditionForm.vue b/src/components/FavoriteEditionForm.vue index f93479342..df3316e73 100644 --- a/src/components/FavoriteEditionForm.vue +++ b/src/components/FavoriteEditionForm.vue @@ -21,7 +21,6 @@ :clear-on-select="false" :preserve-search="false" :placeholder="categoryPH" - inputLabel="label" :options="formattedCategories" :user-select="false" @input="onCategorySelected" From 5d529cbd654e74705355ab4b4c3c3e2bfc7d4d72 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Sim=C3=B3=20Albert=20i=20Beltran?= Date: Thu, 23 Jul 2026 21:23:58 +0200 Subject: [PATCH 2/2] fix: category selection not applying in favorite edit form MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The category dropdown used the @input event to detect selections, but NcSelect (from @nextcloud/vue v9) only emits update:modelValue. The handler never fired, leaving the internal category state stale while the visual v-model appeared correct. Replace @input with @update:modelValue so the onCategorySelected handler runs when a category is picked from the dropdown. Signed-off-by: Simó Albert i Beltran --- src/components/FavoriteEditionForm.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/FavoriteEditionForm.vue b/src/components/FavoriteEditionForm.vue index df3316e73..e099536a4 100644 --- a/src/components/FavoriteEditionForm.vue +++ b/src/components/FavoriteEditionForm.vue @@ -23,7 +23,7 @@ :placeholder="categoryPH" :options="formattedCategories" :user-select="false" - @input="onCategorySelected" + @update:modelValue="onCategorySelected" @search="onSearchChange">