Upload failed with period at the end of the question

[gyuris]

File upload fails if there is a period at the end of the question and Windows file name compatibility is enabled.

To Reproduce
Steps to reproduce the behavior:

1. Enable Windows compatible filenames. (/settings/admin)
2. Create a new form with a file upload field. Name it for example: Upload a file. Period is important!
3. Try to upload a file: Internal Server Error (The folder cannot be found.)

Expected behavior

Upload Successful.

Nextcloud:

• Nextcloud-Version: 33.0.6
• Forms-Version: 5.3.2

[Chartman123]

@gyuris could you please see if you get any errors in the browser console or in the Nextcloud log?

[gyuris]

I suspect the problem is that, in Windows compatibility mode, a file or folder name cannot end with a period, and the folder where the plugin would place the uploaded file isn't being created.

I hope you asked these:

admin_audit:

    NotFoundExceptionException thrown in file create:

    /var/www/html/apps/admin_audit/lib/Actions/Files.php84. sor

    OC\Files\Node\NonExistingFolder->getId()

    /var/www/html/apps/admin_audit/lib/AppInfo/Application.php189. sor

    OCA\AdminAudit\Actions\Files->create(
      "*** sensitive parameters replaced ***"
    )

    /var/www/html/3rdparty/symfony/event-dispatcher/EventDispatcher.php220. sor

    OCA\AdminAudit\AppInfo\Application->OCA\AdminAudit\AppInfo\{closure}(
      "*** sensitive parameters replaced ***"
    )

    /var/www/html/3rdparty/symfony/event-dispatcher/EventDispatcher.php56. sor

    Symfony\Component\EventDispatcher\EventDispatcher->callListeners(
      [
        {
          "__class__": "Closure"
        },
        {
          "__class__": "Closure"
        },
        {
          "__class__": "Closure"
        }
      ],
      "*** sensitive parameters replaced ***",
      "*** sensitive parameters replaced ***"
    )

    /var/www/html/lib/private/EventDispatcher/EventDispatcher.php67. sor

    Symfony\Component\EventDispatcher\EventDispatcher->dispatch(
      "*** sensitive parameters replaced ***",
      "*** sensitive parameters replaced ***"
    )

    /var/www/html/lib/private/EventDispatcher/EventDispatcher.php79. sor

    OC\EventDispatcher\EventDispatcher->dispatch(
      "*** sensitive parameters replaced ***",
      "*** sensitive parameters replaced ***"
    )

    /var/www/html/lib/private/Files/Node/HookConnector.php101. sor

    OC\EventDispatcher\EventDispatcher->dispatchTyped(
      "*** sensitive parameters replaced ***"
    )

    /var/www/html/lib/private/legacy/OC_Hook.php85. sor

    OC\Files\Node\HookConnector->postCreate(
      {
        "run": true,
        "path": "/Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file."
      }
    )

    /var/www/html/lib/private/Files/View.php1323. sor

    OC_Hook::emit(
      "OC_Filesystem",
      "post_create",
      {
        "run": true,
        "path": "/Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file."
      }
    )

    /var/www/html/lib/private/Files/View.php1255. sor

    OC\Files\View->runHooks(
      [
        "create",
        "write"
      ],
      "/Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file.",
      true
    )

    /var/www/html/lib/private/Files/View.php213. sor

    OC\Files\View->basicOperation(
      "mkdir",
      "/gyuris.gellert/files/Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file.",
      [
        "create",
        "write"
      ]
    )

    /var/www/html/lib/private/Files/Node/Folder.php134. sor

    OC\Files\View->mkdir(
      "/gyuris.gellert/files/Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file."
    )

    OC\Files\Node\Folder->newFolder(
      "Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file."
    )

    /var/www/html/lib/private/Files/Node/LazyFolder.php66. sor

    undefinedundefinedcall_user_func_array(
      [
        {
          "__class__": "OC\\Files\\Node\\Folder"
        },
        "newFolder"
      ],
      [
        "Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file."
      ]
    )

    /var/www/html/lib/private/Files/Node/LazyFolder.php434. sor

    OC\Files\Node\LazyFolder->__call(
      "newFolder",
      [
        "Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file."
      ]
    )

    /var/www/html/custom_apps/forms/lib/Controller/ApiController.php1774. sor

    OC\Files\Node\LazyFolder->newFolder(
      "Forms/unsubmitted/1783158340.8892/176 -/1685 - Upload a file."
    )

    /var/www/html/lib/private/AppFramework/Http/Dispatcher.php205. sor

    OCA\Forms\Controller\ApiController->uploadFiles(
      176,
      1685,
      "null"
    )

    /var/www/html/lib/private/AppFramework/Http/Dispatcher.php118. sor

    OC\AppFramework\Http\Dispatcher->executeController(
      {
        "__class__": "OCA\\Forms\\Controller\\ApiController"
      },
      "uploadFiles"
    )

    /var/www/html/lib/private/AppFramework/App.php153. sor

    OC\AppFramework\Http\Dispatcher->dispatch(
      {
        "__class__": "OCA\\Forms\\Controller\\ApiController"
      },
      "uploadFiles"
    )

    /var/www/html/lib/private/Route/Router.php321. sor

    OC\AppFramework\App::main(
      "OCA\\Forms\\Controller\\ApiController",
      "uploadFiles",
      {
        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
      },
      {
        "_route": "ocs.forms.api.uploadfiles",
        "formId": "176",
        "questionId": "1685"
      }
    )

    /var/www/html/ocs/v1.php61. sor

    OC\Route\Router->match(
      "/ocsapp/apps/forms/api/v3/forms/176/submissions/files/1685"
    )

    /var/www/html/ocs/v2.php8. sor

    undefinedundefinedrequire_once(
      "/var/www/html/ocs/v1.php"
    )

no app in context:

NotFoundExceptionException thrown: OCP\Files\NotFoundException

    /var/www/html/lib/private/Files/Node/Node.php231. sor

    OC\Files\Node\Node->getFileInfo(
      false
    )

    /var/www/html/lib/private/Files/Node/Node.php131. sor

    OC\Files\Node\Node->getPermissions()

    /var/www/html/lib/private/Files/Node/Folder.php170. sor

    OC\Files\Node\Node->checkPermissions(
      4
    )

    /var/www/html/custom_apps/forms/lib/Controller/ApiController.php1778. sor

    OC\Files\Node\Folder->newFile(
      "Sample.pdf",
      null
    )

    /var/www/html/lib/private/AppFramework/Http/Dispatcher.php205. sor

    OCA\Forms\Controller\ApiController->uploadFiles(
      176,
      1685,
      "null"
    )

    /var/www/html/lib/private/AppFramework/Http/Dispatcher.php118. sor

    OC\AppFramework\Http\Dispatcher->executeController(
      {
        "__class__": "OCA\\Forms\\Controller\\ApiController"
      },
      "uploadFiles"
    )

    /var/www/html/lib/private/AppFramework/App.php153. sor

    OC\AppFramework\Http\Dispatcher->dispatch(
      {
        "__class__": "OCA\\Forms\\Controller\\ApiController"
      },
      "uploadFiles"
    )

    /var/www/html/lib/private/Route/Router.php321. sor

    OC\AppFramework\App::main(
      "OCA\\Forms\\Controller\\ApiController",
      "uploadFiles",
      {
        "__class__": "OC\\AppFramework\\DependencyInjection\\DIContainer"
      },
      {
        "_route": "ocs.forms.api.uploadfiles",
        "formId": "176",
        "questionId": "1685"
      }
    )

    /var/www/html/ocs/v1.php61. sor

    OC\Route\Router->match(
      "/ocsapp/apps/forms/api/v3/forms/176/submissions/files/1685"
    )

    /var/www/html/ocs/v2.php8. sor

    undefinedundefinedrequire_once(
      "/var/www/html/ocs/v1.php"
    )