From 8fab6b72beda50fc2c6e0a1dffb28b605eb49fd9 Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Thu, 25 Jun 2026 12:52:24 +0200 Subject: [PATCH 1/4] docs(events): Add ShareReviewAccessCheckEvent see https://github.com/nextcloud/server/pull/61543 Signed-off-by: Andy Scherzinger --- developer_manual/basics/_available_events_ocp.rst | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/developer_manual/basics/_available_events_ocp.rst b/developer_manual/basics/_available_events_ocp.rst index 8efc668cc80..858af2fa2e7 100644 --- a/developer_manual/basics/_available_events_ocp.rst +++ b/developer_manual/basics/_available_events_ocp.rst @@ -817,6 +817,13 @@ Event that allows to register a feature policy header to a request. .. versionadded:: 28 +``OCP\Share\Events\ShareReviewAccessCheckEvent`` +************************************************ + +.. versionadded:: 34.0.2 + +Authorization gate event dispatched by a ShareReview source before deleting an app-managed share on behalf of a ShareReview operator. + ``OCP\Share\Events\VerifyMountPointEvent`` ****************************************** From fa9e2a37b1f22bff847751796f335b290811d046 Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Thu, 2 Jul 2026 09:41:32 +0200 Subject: [PATCH 2/4] docs: update share-review event namespaces to OCP\Share\ShareReview Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger --- .../basics/_available_events_ocp.rst | 17 ++++++++++++----- 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/developer_manual/basics/_available_events_ocp.rst b/developer_manual/basics/_available_events_ocp.rst index 858af2fa2e7..e0eb0a54663 100644 --- a/developer_manual/basics/_available_events_ocp.rst +++ b/developer_manual/basics/_available_events_ocp.rst @@ -817,18 +817,25 @@ Event that allows to register a feature policy header to a request. .. versionadded:: 28 -``OCP\Share\Events\ShareReviewAccessCheckEvent`` -************************************************ +``OCP\Share\Events\VerifyMountPointEvent`` +****************************************** + +.. versionadded:: 19 + + +``OCP\Share\ShareReview\Events\ShareReviewAccessCheckEvent`` +************************************************************ .. versionadded:: 34.0.2 Authorization gate event dispatched by a ShareReview source before deleting an app-managed share on behalf of a ShareReview operator. -``OCP\Share\Events\VerifyMountPointEvent`` -****************************************** +``OCP\Share\ShareReview\RegisterShareReviewSourceEvent`` +******************************************************** -.. versionadded:: 19 +.. versionadded:: 34.0.2 +Event dispatched by a share-review app to collect share sources from other apps. Listeners register the class name of their ``OCP\Share\ShareReview\IShareReviewSource`` implementation. ``OCP\SpeechToText\Events\TranscriptionFailedEvent`` **************************************************** From ff6b6b6f6a4e43d80e51d42523b3044fc97f0e6f Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Thu, 2 Jul 2026 23:39:49 +0200 Subject: [PATCH 3/4] docs: extend share-review event descriptions with dispatcher and listener roles Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger --- developer_manual/basics/_available_events_ocp.rst | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/developer_manual/basics/_available_events_ocp.rst b/developer_manual/basics/_available_events_ocp.rst index e0eb0a54663..0688eff9b61 100644 --- a/developer_manual/basics/_available_events_ocp.rst +++ b/developer_manual/basics/_available_events_ocp.rst @@ -828,14 +828,20 @@ Event that allows to register a feature policy header to a request. .. versionadded:: 34.0.2 -Authorization gate event dispatched by a ShareReview source before deleting an app-managed share on behalf of a ShareReview operator. +Authorization gate for deleting an app-managed share through a share-review app. Dispatched by the app that owns +the share (its ``OCP\Share\ShareReview\IShareReviewSource`` implementation) at the beginning of ``deleteShare()``, +before anything is deleted. The share-review app listens to this event and answers with ``grantAccess()`` or +``denyAccess()`` depending on whether the current user is an authorized share-review operator; apps that merely +expose shares must not listen to it. The event is default-deny: if no listener responds, the share must not be +deleted. Once denied, further grants are ignored and event propagation is stopped. ``OCP\Share\ShareReview\RegisterShareReviewSourceEvent`` ******************************************************** .. versionadded:: 34.0.2 -Event dispatched by a share-review app to collect share sources from other apps. Listeners register the class name of their ``OCP\Share\ShareReview\IShareReviewSource`` implementation. +Event dispatched by a share-review app to collect share sources from other apps. Listeners register the class name +of their ``OCP\Share\ShareReview\IShareReviewSource`` implementation. ``OCP\SpeechToText\Events\TranscriptionFailedEvent`` **************************************************** From fc470a5666a24102591e92fb39788c9d4dc80330 Mon Sep 17 00:00:00 2001 From: Andy Scherzinger Date: Tue, 7 Jul 2026 18:28:09 +0200 Subject: [PATCH 4/4] docs: mention ShareReviewEntry return type of share-review sources Assisted-by: Claude Code:claude-fable-5 Signed-off-by: Andy Scherzinger --- developer_manual/basics/_available_events_ocp.rst | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/developer_manual/basics/_available_events_ocp.rst b/developer_manual/basics/_available_events_ocp.rst index 0688eff9b61..293a09de9de 100644 --- a/developer_manual/basics/_available_events_ocp.rst +++ b/developer_manual/basics/_available_events_ocp.rst @@ -841,7 +841,8 @@ deleted. Once denied, further grants are ignored and event propagation is stoppe .. versionadded:: 34.0.2 Event dispatched by a share-review app to collect share sources from other apps. Listeners register the class name -of their ``OCP\Share\ShareReview\IShareReviewSource`` implementation. +of their ``OCP\Share\ShareReview\IShareReviewSource`` implementation, whose ``getShares()`` method returns a list of +``OCP\Share\ShareReview\ShareReviewEntry`` objects. ``OCP\SpeechToText\Events\TranscriptionFailedEvent`` ****************************************************