Skip to content

Commit 21fc3f5

Browse files
authored
Merge pull request #9102 from nextcloud/i2h3/fix/9686962-root-changes
fix(file-provider): Root container enumeration to process remote updates correctly.
2 parents 7ce3b84 + cb65d1a commit 21fc3f5

5 files changed

Lines changed: 8 additions & 8 deletions

File tree

shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/FileProviderExtension.swift

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ import OSLog
4848
// This does lead to long load times when a file provider domain is initially configured.
4949
// We can instead do a fast enumeration where we only scan folders as the user navigates through
5050
// them, thereby avoiding this issue; the trade-off is that we will be unable to detect
51-
// materialised file moves to unexplored folders, therefore deleting the item when we could have
51+
// materialized file moves to unexplored folders, therefore deleting the item when we could have
5252
// just moved it instead.
5353
//
5454
// Since it's not desirable to cancel a long recursive enumeration half-way through, we do the
@@ -500,7 +500,7 @@ import OSLog
500500
}
501501

502502
let materialisedEnumerator = fpManager.enumeratorForMaterializedItems()
503-
let materialisedObserver = MaterialisedEnumerationObserver(ncKitAccount: ncAccount.ncKitAccount, dbManager: dbManager, log: log) { _, _ in
503+
let materialisedObserver = MaterializedEnumerationObserver(account: ncAccount, dbManager: dbManager, log: log) { _, _ in
504504
completionHandler()
505505
}
506506
let startingPage = NSFileProviderPage(NSFileProviderPage.initialPageSortedByName as Data)

shell_integration/MacOSX/NextcloudIntegration/FileProviderExt/Services/FPUIExtensionServiceSource.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ class FPUIExtensionServiceSource: NSObject, NSFileProviderServiceSource, NSXPCLi
9090
logger.error("Could not get db manager for \(account)")
9191
return nil
9292
}
93-
guard let item = dbManager.itemMetadataFromFileProviderItemIdentifier(identifier) else {
93+
guard let item = dbManager.itemMetadata(identifier) else {
9494
logger.error("No item \(rawIdentifier) in db, no shares.")
9595
return nil
9696
}

shell_integration/MacOSX/NextcloudIntegration/NextcloudIntegration.xcodeproj/project.pbxproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@
225225
/* End PBXFileReference section */
226226

227227
/* Begin PBXFileSystemSynchronizedRootGroup section */
228-
AAD7F6032EAA11670071D385 /* gui */ = {isa = PBXFileSystemSynchronizedRootGroup; explicitFileTypes = {}; explicitFolders = (); name = gui; path = /Users/iva/Projekte/nextcloud/desktop/src/gui; sourceTree = "<absolute>"; };
228+
AAFDB1862ECB63AD00C26AE7 /* src */ = {isa = PBXFileSystemSynchronizedRootGroup; explicitFileTypes = {}; explicitFolders = (); name = src; path = /Users/iva/Projekte/nextcloud/desktop/src; sourceTree = "<absolute>"; };
229229
/* End PBXFileSystemSynchronizedRootGroup section */
230230

231231
/* Begin PBXFrameworksBuildPhase section */
@@ -407,7 +407,7 @@
407407
C2B573941B1CD88000303B36 = {
408408
isa = PBXGroup;
409409
children = (
410-
AAD7F6032EAA11670071D385 /* gui */,
410+
AAFDB1862ECB63AD00C26AE7 /* src */,
411411
AA27A4E32E93C0D700665051 /* README.md */,
412412
C2B573B31B1CD91E00303B36 /* desktopclient */,
413413
AA0A6B1C2E8EA948007F4A7A /* NextcloudDev */,

shell_integration/MacOSX/NextcloudIntegration/NextcloudIntegration.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/gui/macOS/fileprovideritemmetadata_mac.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ QString nsNameComponentsToLocalisedQString(NSPersonNameComponents *const nameCom
9090

9191
if (metadata._documentSize == 0) {
9292
// If the document size is 0, we can try to get the size of the file
93-
// directly from its path. These are all materialised files anyway
93+
// directly from its path. These are all materialized files anyway
9494
// so the size will be properly represented
9595
const auto path = metadata.userVisiblePath();
9696
const auto fileInfo = QFileInfo(path);

0 commit comments

Comments
 (0)