Skip to content

Commit f9f3104

Browse files
authored
Merge pull request #7726 from nextcloud/feat/hide-fields-in-json
fix(federation): hide not required json fields
2 parents 177076f + b65cc2a commit f9f3104

3 files changed

Lines changed: 13 additions & 12 deletions

File tree

lib/Db/Acl.php

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -65,4 +65,11 @@ public function getPermission(int $permission): bool {
6565
default => false,
6666
};
6767
}
68+
69+
public function jsonSerialize(): array {
70+
$json = parent::jsonSerialize();
71+
unset($json['token']);
72+
73+
return $json;
74+
}
6875
}

tests/data/deck.json

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -434,8 +434,7 @@
434434
"permissionEdit": true,
435435
"permissionShare": false,
436436
"permissionManage": false,
437-
"owner": false,
438-
"token": null
437+
"owner": false
439438
},
440439
{
441440
"id": 5,
@@ -450,8 +449,7 @@
450449
"permissionEdit": false,
451450
"permissionShare": true,
452451
"permissionManage": false,
453-
"owner": false,
454-
"token": null
452+
"owner": false
455453
},
456454
{
457455
"id": 6,
@@ -466,8 +464,7 @@
466464
"permissionEdit": false,
467465
"permissionShare": false,
468466
"permissionManage": true,
469-
"owner": false,
470-
"token": null
467+
"owner": false
471468
}
472469
],
473470
"permissions": {

tests/unit/Db/AclTest.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,7 @@ public function testJsonSerialize() {
5959
'permissionEdit' => true,
6060
'permissionShare' => true,
6161
'permissionManage' => true,
62-
'owner' => false,
63-
'token' => null
62+
'owner' => false
6463
], $acl->jsonSerialize());
6564
$acl = $this->createAclGroup();
6665
$this->assertEquals([
@@ -71,8 +70,7 @@ public function testJsonSerialize() {
7170
'permissionEdit' => true,
7271
'permissionShare' => true,
7372
'permissionManage' => true,
74-
'owner' => false,
75-
'token' => null
73+
'owner' => false
7674
], $acl->jsonSerialize());
7775
}
7876

@@ -87,8 +85,7 @@ public function testSetOwner() {
8785
'permissionEdit' => true,
8886
'permissionShare' => true,
8987
'permissionManage' => true,
90-
'owner' => true,
91-
'token' => null
88+
'owner' => true
9289
], $acl->jsonSerialize());
9390
}
9491

0 commit comments

Comments
 (0)