Updating the command run implementation to perform error check of projectRoot before running run method.

Author: adrianwebb

package.json

@@ -1,6 +1,6 @@
 {
     "name": "@nexical/cli-core",
-    "version": "0.1.8",
+    "version": "0.1.9",
     "type": "module",
     "main": "dist/index.js",
     "types": "dist/index.d.ts",

src/BaseCommand.ts

@@ -32,17 +32,19 @@ export abstract class BaseCommand implements CommandInterface {
             this.projectRoot = await findProjectRoot(this.cli.name, process.cwd());
         }
 
-        const requiresProject = (this.constructor as any).requiresProject;
+        if (this.projectRoot) {
+            this.config = await loadConfig(this.cli.name, this.projectRoot);
+            logger.debug(`Loaded config from ${this.projectRoot}`);
+        }
+    }
 
+    async runInit(options: any): Promise<void> {
+        const requiresProject = (this.constructor as any).requiresProject;
         if (requiresProject && !this.projectRoot) {
             this.error(`This command requires to be run within an app project (${this.cli.name}.yml not found).`, 1);
-            return; // TS doesn't know error exits
-        }
-
-        if (this.projectRoot) {
-            this.config = await loadConfig(this.cli.name, this.projectRoot);
-            // logger.debug(`Loaded config from ${this.projectRoot}`);
+            return;
         }
+        await this.run(options);
     }
 
     abstract run(options: any): Promise<void>;

src/CLI.ts

@@ -315,7 +315,7 @@ export class CLI {
         try {
             const instance = new CommandClass(this, options);
             await instance.init();
-            await instance.run(options);
+            await instance.runInit(options);
         } catch (e: any) {
             console.error(pc.red(e.message));
             if (options.debug) console.error(e.stack);

test/unit/core/BaseCommand.test.ts

@@ -84,11 +84,23 @@ describe('BaseCommand', () => {
         const cli = new CLI({ commandName: 'app' });
         const cmd = new ProjectRequiredCommand(cli, {});
         await cmd.init();
+        await cmd.runInit({});
 
         expect(consoleLogSpy).toHaveBeenCalledWith(pc.red('✖ This command requires to be run within an app project (app.yml not found).'));
         expect(process.exit).toHaveBeenCalledWith(1);
     });
 
+    it('should execute run method via runInit', async () => {
+        const cli = new CLI({ commandName: 'app' });
+        const cmd = new TestCommand(cli);
+        const runSpy = vi.spyOn(cmd, 'run');
+
+        await cmd.init();
+        await cmd.runInit({});
+
+        expect(runSpy).toHaveBeenCalled();
+    });
+
     it('should log success', () => {
         const cli = new CLI({ commandName: 'app' });
         const cmd = new TestCommand(cli);

test/unit/core/ConfigLoading.test.ts

@@ -38,8 +38,12 @@ describe('Config Loading & Error Messaging', () => {
         (ConfigUtils.loadConfig as any).mockResolvedValue({});
 
         await command.init();
+        // project root finding happens in init, verification happens in runInit
+        // but this test marks requiresProject=true, so if we don't call runInit, we only verify init logic.
+        // The original test verified init logic calling loadConfig.
 
         expect(ConfigUtils.findProjectRoot).toHaveBeenCalledWith('astrical', expect.any(String));
+        // loadConfig is called in init if root is found
         expect(ConfigUtils.loadConfig).toHaveBeenCalledWith('astrical', '/some/path');
     });
 
@@ -50,6 +54,7 @@ describe('Config Loading & Error Messaging', () => {
         (ConfigUtils.findProjectRoot as any).mockResolvedValue(null);
 
         await command.init();
+        await command.runInit({});
 
         expect(consoleLogSpy).toHaveBeenCalledWith(
             expect.stringContaining(pc.red('✖ This command requires to be run within an app project (astrical.yml not found).'))
@@ -64,6 +69,7 @@ describe('Config Loading & Error Messaging', () => {
         (ConfigUtils.findProjectRoot as any).mockResolvedValue(null);
 
         await command.init();
+        await command.runInit({});
 
         expect(consoleLogSpy).toHaveBeenCalledWith(
             expect.stringContaining(pc.red('✖ This command requires to be run within an app project (app.yml not found).'))