Redesign profile settings as dropdown, UI polish, and bug fixes (#136)

* Redesign profile settings as dropdown, UI refinements

Move profile settings into a collapsible dropdown menu on user show
page (both desktop and mobile). Reorder toggles to place newsletter
before open-to-work, rename "Newsletter" to "Receive news". Replace
"Sort:" text labels with sort icon SVG. Adjust avatar sizes on
community index and testimonial heading styling.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Styled somehow the stupid bange in testimonial

* Fix char counter submit target guard, conditional mobile menu controller

Add hasSubmitTarget check in char_counter_controller to prevent errors
when submit target is absent. Skip mobile-menu Stimulus controller on
nav_minimal pages.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Fix settings menu on mobile

* Trying to fix stuck quote processing update

* Trying to fix stuck quote processing update

* Preserve existing bio when GitHub returns empty value on refresh

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Preserve existing name, website, and twitter when GitHub returns empty values

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Don't overwrite today's star snapshot on sign-in

When a user signs in mid-day, record_snapshot! was updating the existing
snapshot created by the 2am scheduled job, making tomorrow's delta appear
smaller. Now sign-in only creates a snapshot if none exists for today,
while the scheduled batch job still force-updates to stay authoritative.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Remove legacy github_repos JSON column and rake tasks

The github_repos text column on users has been replaced by the Project
model. Remove the column and the two legacy rake tasks (github:update_all,
github:update_user) that still wrote to it. The proper github:update_all_job
task remains.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* Replace portrait-phone CSS overrides with Tailwind responsive utilities for Open to Work badge

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

Author: newstler

app/assets/images/sort.svg

@@ -324,6 +324,9 @@ def post_path_for(post)
   def cross_domain_url(domain_type, path = "/")
     return path unless Rails.env.production?
 
+    # No Warden context (e.g. rendering from a background job broadcast)
+    return path unless respond_to?(:request) && request.present? && request.env["warden"].present?
+
     domains = Rails.application.config.x.domains
     host = (domain_type == :primary) ? domains.primary : domains.community
 

app/helpers/application_helper.rb

@@ -28,14 +28,16 @@ export default class extends Controller {
       colorClass = `${pill} bg-red-100 text-red-600`
     }
 
-    if (isValid) {
-      this.submitTarget.disabled = false
-      this.submitTarget.classList.remove("opacity-50", "cursor-not-allowed")
-      this.submitTarget.classList.add("cursor-pointer", "hover:bg-red-700")
-    } else {
-      this.submitTarget.disabled = true
-      this.submitTarget.classList.add("opacity-50", "cursor-not-allowed")
-      this.submitTarget.classList.remove("cursor-pointer", "hover:bg-red-700")
+    if (this.hasSubmitTarget) {
+      if (isValid) {
+        this.submitTarget.disabled = false
+        this.submitTarget.classList.remove("opacity-50", "cursor-not-allowed")
+        this.submitTarget.classList.add("cursor-pointer", "hover:bg-red-700")
+      } else {
+        this.submitTarget.disabled = true
+        this.submitTarget.classList.add("opacity-50", "cursor-not-allowed")
+        this.submitTarget.classList.remove("cursor-pointer", "hover:bg-red-700")
+      }
     }
 
     this.counterTargets.forEach(counter => {

app/javascript/controllers/char_counter_controller.js

@@ -21,6 +21,7 @@ def perform(testimonial)
     unless parsed
       Rails.logger.error "Failed to generate testimonial fields for testimonial #{testimonial.id}"
       testimonial.update!(ai_feedback: "We couldn't process your testimonial right now. Please try again later.")
+      broadcast_update(testimonial)
       return
     end
 
@@ -36,6 +37,7 @@ def perform(testimonial)
 
     unless parsed
       testimonial.update!(ai_feedback: "We couldn't process your testimonial right now. Please try again later.")
+      broadcast_update(testimonial)
       return
     end
 
@@ -48,6 +50,7 @@ def perform(testimonial)
   rescue JSON::ParserError => e
     Rails.logger.error "Failed to parse AI response for testimonial #{testimonial.id}: #{e.message}"
     testimonial.update!(ai_feedback: "We couldn't process your testimonial right now. Please try again later.")
+    broadcast_update(testimonial)
   end
 
   private
@@ -100,6 +103,15 @@ def generate_fields(system_prompt, user_prompt)
     result ? JSON.parse(result) : nil
   end
 
+  def broadcast_update(testimonial)
+    Turbo::StreamsChannel.broadcast_replace_to(
+      "testimonial_#{testimonial.id}",
+      target: "testimonial_section",
+      partial: "testimonials/section",
+      locals: { testimonial: testimonial, user: testimonial.user }
+    )
+  end
+
   def heading_taken?(heading, testimonial_id)
     Testimonial.where.not(id: testimonial_id).exists?(heading: heading)
   end

app/jobs/generate_testimonial_fields_job.rb

@@ -18,9 +18,9 @@ def stars_gained
     [ snapshots.first - snapshots.last, 0 ].max
   end
 
-  def record_snapshot!
+  def record_snapshot!(force: false)
     snapshot = star_snapshots.find_or_initialize_by(recorded_on: Date.current)
-    snapshot.update!(stars: stars)
+    snapshot.update!(stars: stars) if snapshot.new_record? || force
     snapshot
   end
 end

app/models/project.rb

@@ -166,11 +166,11 @@ def self.update_user_from_graphql(user, profile_data, repos_data)
     user.update!(
       username: profile_data[:login],
       email: profile_data[:email] || user.email,
-      name: profile_data[:name],
-      bio: profile_data[:bio],
+      name: profile_data[:name] || user.name,
+      bio: profile_data[:bio] || user.bio,
       company: profile_data[:company],
-      website: profile_data[:websiteUrl].presence,
-      twitter: profile_data[:twitterUsername].presence,
+      website: profile_data[:websiteUrl].presence || user.website,
+      twitter: profile_data[:twitterUsername].presence || user.twitter,
       location: profile_data[:location],
       avatar_url: profile_data[:avatarUrl],
       github_data_updated_at: Time.current
@@ -190,11 +190,11 @@ def self.update_user_from_graphql(user, profile_data, repos_data)
       }
     end
 
-    sync_projects!(user, repos)
+    sync_projects!(user, repos, force_snapshot: true)
   end
 
   # Sync GitHub repos to Project records with star snapshot tracking
-  def self.sync_projects!(user, repos_data)
+  def self.sync_projects!(user, repos_data, force_snapshot: false)
     current_urls = repos_data.map { |r| r[:github_url] || r[:url] }
 
     # Soft-archive projects no longer returned by GitHub
@@ -216,7 +216,7 @@ def self.sync_projects!(user, repos_data)
       )
 
       project.save!
-      project.record_snapshot!
+      project.record_snapshot!(force: force_snapshot)
     end
 
     # Recalculate cached stats on user
@@ -255,11 +255,11 @@ def update_from_oauth_data
     user.update!(
       username: auth_data.info.nickname,
       email: auth_data.info.email,
-      name: raw_info.name,
-      bio: raw_info.bio,
+      name: raw_info.name || user.name,
+      bio: raw_info.bio || user.bio,
       company: raw_info.company,
-      website: raw_info.blog.presence,
-      twitter: raw_info.twitter_username.presence,
+      website: raw_info.blog.presence || user.website,
+      twitter: raw_info.twitter_username.presence || user.twitter,
       location: raw_info.location,
       avatar_url: auth_data.info.image
     )
@@ -286,11 +286,11 @@ def update_from_api
       user.update!(
         username: data["login"],
         email: data["email"] || user.email,
-        name: data["name"],
-        bio: data["bio"],
+        name: data["name"] || user.name,
+        bio: data["bio"] || user.bio,
         company: data["company"],
-        website: data["blog"],
-        twitter: data["twitter_username"],
+        website: data["blog"].presence || user.website,
+        twitter: data["twitter_username"] || user.twitter,
         location: data["location"],
         avatar_url: data["avatar_url"]
       )

app/services/github_data_fetcher.rb

@@ -65,7 +65,7 @@
 
                 <%# User tile - extra top margin on mobile/tablet to account for speech bubble tail %>
                 <div class="lg:flex-1 lg:basis-0 flex items-end mt-2 lg:mt-0">
-                  <%= render "users/user_tile", user: testimonial.user, frameless: true, avatar_size: "w-20 h-[72px] md:w-36 md:h-[130px]", compact: true %>
+                  <%= render "users/user_tile", user: testimonial.user, frameless: true, avatar_size: "w-20 h-[72px] md:w-36 md:h-[130px]", compact: true, badge_size: "xs" %>
                 </div>
               </div>
             </div>

app/views/home/_testimonial_carousel.html.erb

@@ -90,7 +90,7 @@
     <noscript><img src="https://nullitics.com/n.gif?u=<%= request.original_url %><%= "&c=#{country_code}" if country_code.present? %>" alt="" style="position:absolute;left:-9999px" /></noscript>
 
     <% community_nav = content_for?(:nav_community_style) || (controller_name == 'users' && ['index', 'show'].include?(action_name)) %>
-    <nav class="<%= community_nav ? 'bg-gray-50 pt-4 [@media(min-width:640px)_and_(min-height:500px)]:pt-6' : 'bg-white shadow-sm py-4' %> sticky top-0 z-50" data-controller="mobile-menu" data-action="click@window->mobile-menu#hide">
+    <nav class="<%= community_nav ? 'bg-gray-50 pt-4 [@media(min-width:640px)_and_(min-height:500px)]:pt-6' : 'bg-white shadow-sm py-4' %> sticky top-0 z-50" <%= 'data-controller="mobile-menu" data-action="click@window->mobile-menu#hide"'.html_safe unless content_for?(:nav_minimal) %>>
       <div class="max-w-7xl mx-auto px-4 sm:px-6 lg:px-8">
         <% centered_mobile_nav = content_for?(:nav_community_style) || (controller_name == 'users' && ['index', 'show'].include?(action_name)) %>
         <div class="flex items-center <%= centered_mobile_nav ? 'h-14 [@media(min-width:640px)_and_(min-height:500px)]:h-20 justify-center' : 'h-16 justify-between' %>">

app/views/layouts/application.html.erb

@@ -12,6 +12,7 @@
 <% show_badge = local_assigns.key?(:show_open_to_work) ? show_open_to_work : user.open_to_work? %>
 <% small_badge = local_assigns[:badge_size] == "small" %>
 <% tiny_badge = local_assigns[:badge_size] == "tiny" %>
+<% xs_badge = local_assigns[:badge_size] == "xs" %>
 <% map_badge = local_assigns[:badge_size] == "map" %>
 <% thick_border = local_assigns[:thick_border] == true %>
 <div class="<%= size %> flex-shrink-0 relative overflow-visible">
@@ -45,6 +46,10 @@
       <div class="absolute -bottom-[1px] left-1/2 -translate-x-1/2 z-10">
         <span class="inline-block px-[3px] py-[0.5px] text-[5px] font-bold uppercase tracking-wide text-white bg-red-600 rounded-full whitespace-nowrap" style="line-height:1.2;letter-spacing:0.3px;">Open to work</span>
       </div>
+    <% elsif xs_badge %>
+      <div class="absolute -bottom-[1px] md:bottom-1 left-1/2 -translate-x-1/2 z-10">
+        <span class="inline-block px-[3px] md:px-2 py-[0.5px] md:py-0.5 text-[5px] md:text-[10px] font-bold uppercase leading-[1.2] tracking-[0.3px] text-white bg-red-600 rounded-full whitespace-nowrap shadow-sm">Open to work</span>
+      </div>
     <% else %>
       <div class="absolute <%= small_badge ? 'bottom-0' : 'bottom-1' %> left-1/2 -translate-x-1/2 z-10">
         <span class="inline-block <%= small_badge ? 'px-1.5 py-px text-[8px]' : 'px-2 py-0.5 text-[10px]' %> font-bold uppercase tracking-wide text-white bg-red-600 rounded-full whitespace-nowrap shadow-sm">

app/views/shared/_gem_avatar.html.erb

@@ -1,6 +1,6 @@
-<div id="<%= local_assigns[:wrapper_id] || 'profile_settings' %>" class="md:space-y-3">
+<div id="<%= local_assigns[:wrapper_id] || 'profile_settings' %>" class="space-y-0">
   <%# Public Profile Toggle %>
-  <div class="flex items-center justify-between gap-4 py-3 md:py-0 border-t border-gray-100 md:border-t-0">
+  <div class="flex items-center justify-between gap-4 py-3">
     <span class="text-sm font-medium text-gray-500">Public profile</span>
     <%= button_to toggle_public_user_settings_path,
         method: :post,
@@ -12,34 +12,34 @@
     <% end %>
   </div>
 
-  <%# Open to Work Toggle %>
-  <div class="flex items-center justify-between gap-4 py-3 md:py-0 border-t border-gray-100 md:border-t-0">
-    <span class="text-sm font-medium text-gray-500">Open to work</span>
-    <%= button_to toggle_open_to_work_user_settings_path,
+  <%# Newsletter Toggle %>
+  <div class="flex items-center justify-between gap-4 py-3 border-t border-gray-100">
+    <span class="text-sm font-medium text-gray-500">Receive news</span>
+    <%= button_to toggle_newsletter_user_settings_path,
         method: :post,
-        class: "relative inline-flex h-6 w-11 flex-shrink-0 cursor-pointer rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out focus:outline-none focus:ring-2 focus:ring-red-500 focus:ring-offset-2 #{user.open_to_work? ? 'bg-red-600' : 'bg-gray-400'}",
+        class: "relative inline-flex h-6 w-11 flex-shrink-0 cursor-pointer rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out focus:outline-none focus:ring-2 focus:ring-red-500 focus:ring-offset-2 #{user.unsubscribed_from_newsletter? ? 'bg-gray-400' : 'bg-red-600'}",
         data: { turbo_stream: true } do %>
-      <span class="sr-only">Toggle open to work</span>
+      <span class="sr-only">Toggle newsletter subscription</span>
       <span aria-hidden="true"
-            class="pointer-events-none inline-block h-5 w-5 transform rounded-full bg-white shadow ring-0 transition duration-200 ease-in-out <%= user.open_to_work? ? 'translate-x-4' : 'translate-x-0' %>"></span>
+            class="pointer-events-none inline-block h-5 w-5 transform rounded-full bg-white shadow ring-0 transition duration-200 ease-in-out <%= user.unsubscribed_from_newsletter? ? 'translate-x-0' : 'translate-x-4' %>"></span>
     <% end %>
   </div>
 
-  <%# Newsletter Toggle %>
-  <div class="flex items-center justify-between gap-4 py-3 md:py-0 border-t border-gray-100 md:border-t-0">
-    <span class="text-sm font-medium text-gray-500">Newsletter</span>
-    <%= button_to toggle_newsletter_user_settings_path,
+  <%# Open to Work Toggle %>
+  <div class="flex items-center justify-between gap-4 py-3 border-t border-gray-100">
+    <span class="text-sm font-medium text-gray-500">Open to work</span>
+    <%= button_to toggle_open_to_work_user_settings_path,
         method: :post,
-        class: "relative inline-flex h-6 w-11 flex-shrink-0 cursor-pointer rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out focus:outline-none focus:ring-2 focus:ring-red-500 focus:ring-offset-2 #{user.unsubscribed_from_newsletter? ? 'bg-gray-400' : 'bg-red-600'}",
+        class: "relative inline-flex h-6 w-11 flex-shrink-0 cursor-pointer rounded-full border-2 border-transparent transition-colors duration-200 ease-in-out focus:outline-none focus:ring-2 focus:ring-red-500 focus:ring-offset-2 #{user.open_to_work? ? 'bg-red-600' : 'bg-gray-400'}",
         data: { turbo_stream: true } do %>
-      <span class="sr-only">Toggle newsletter subscription</span>
+      <span class="sr-only">Toggle open to work</span>
       <span aria-hidden="true"
-            class="pointer-events-none inline-block h-5 w-5 transform rounded-full bg-white shadow ring-0 transition duration-200 ease-in-out <%= user.unsubscribed_from_newsletter? ? 'translate-x-0' : 'translate-x-4' %>"></span>
+            class="pointer-events-none inline-block h-5 w-5 transform rounded-full bg-white shadow ring-0 transition duration-200 ease-in-out <%= user.open_to_work? ? 'translate-x-4' : 'translate-x-0' %>"></span>
     <% end %>
   </div>
 
   <%# Sign Out Button %>
-  <div class="md:pt-0">
+  <div class="pt-1">
     <%= button_to "Sign out", destroy_user_session_path,
         method: :delete,
         data: { turbo: false },