Skip to content
This repository was archived by the owner on Apr 19, 2024. It is now read-only.

Commit 41eb232

Browse files
committed
Fix review comments
1 parent 69795d6 commit 41eb232

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

.github/workflows/test.yml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,12 +2,12 @@
22
name: tests
33

44
on:
5-
pull_request:
65
push:
6+
branches: [master]
77
workflow_dispatch:
8-
inputs:
8+
99
concurrency:
10-
group: dashboard-${{ github.ref }}
10+
group: ${{ github.workflow }}-${{ github.ref }}
1111
cancel-in-progress: true
1212

1313
jobs:
@@ -21,7 +21,7 @@ jobs:
2121

2222
- uses: actions/setup-node@v2
2323
with:
24-
node-version: "12.22.0"
24+
node-version: "12.x"
2525
cache: "npm"
2626
- name: Install dependencies
2727
run: npm install
@@ -51,7 +51,8 @@ jobs:
5151
- name: Upload report to test-reports bucket
5252
if: (steps.run-tests.outcome == 'failure' || steps.run-tests.outcome == 'success') && github.ref == 'refs/heads/develop'
5353
run: |
54-
gsutil -h "Cache-Control: max-age=0, no-store" cp /tmp/coverage_report gs://${{ secrets.TEST_AUTOMATION_STORAGE_BUCKET }}/${{ github.event.repository.name }}/coverage_report
54+
gsutil -h "Cache-Control: max-age=0, no-store" cp \
55+
/tmp/coverage_report gs://${{ secrets.TEST_AUTOMATION_STORAGE_BUCKET }}/${{ github.event.repository.name }}/coverage_report
5556
gsutil acl set project-private gs://${{ secrets.TEST_AUTOMATION_STORAGE_BUCKET }}/${{ github.event.repository.name }}/coverage_report
5657
5758
- name: Publish test coverage report

tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,6 @@
2424
"noEmit": true,
2525
"declaration": true
2626
},
27-
"include": ["./src/**/*", "src/vendor/dygraph-c91c859.min.js"],
27+
"include": ["./src/**/*"],
2828
"exclude": ["/node_modules/", "**/*.test.ts", "**/*.test.tsx"]
2929
}

0 commit comments

Comments
 (0)