get/set() doesn't update settings if resource name has '-'

[omar-o22]

Describe the bug

When trying to change a setting of a resource whose name contains a dash (-) doesn’t update the existing setting. Instead, it creates a new one like this resourceName.setting
[edited]: get() has the same bug
returns the value of resourceName.setting instead of setting

Steps to reproduce

1. Create a resource with a dash in its name, e.g. my-resource
2. Define a setting in its meta.xml:

<setting name="*testSetting" value="1" />

3. Run:

set("*my-resource.testSetting", "2")

Version

Client: v1.6-release-23324 (Windows 10 64-bit)
Server: v1.6-release-23324 (Windows 10 64-bit)

Additional context

/

Relevant log output

Security Policy

• I have read and understood the Security Policy and this issue is not security related.

[Elabyad247]

I was hoping to pick this up as my first contribution but I can't reproduce the bug so I figured I'd ask before digging further.
I set up a resource called hello-mta with <setting name="*testSetting" value="1" /> in it's meta.xml and a no-dash copy hellomta, and a third resource that calls set() and get() on both.
I tried it three ways:

1. set("*hello-mta.testSetting", "2") from the third resource
2. From inside hello-mta with the full form: set("*hello-mta.testSetting", "3")
3. From inside hello-mta with the short form: set("*testSetting", "4")

All three work correctly on both master and v1.6-release and settings.xml ends up with correctly named entries and no duplicates or new ones like the issue describes.

Two things I wanted to ask:

• For @qaisjp , is this still a valid open issue or has it been fixed but the issue wasn't closed?
• For @omar-o22 , if it's still a bug, could you share a bit more detail on how you originally hit it? Any extra context about your setup or the exact steps would help me reproduce it.

Happy to keep digging once I know what I'm missing or doing wrong and whether it's still a valid issue.

[qaisjp]

If you can't reproduce the issue then it may not be valid anymore. If @omar-o22 doesn't respond, we can close the issue.

[omar-o22]

If you can't reproduce the issue then it may not be valid anymore. If @omar-o22 doesn't respond, we can close the issue.

I'll check today

[omar-o22]

Multi Theft Auto v1.7-untested-26553:

And same in Multi Theft Auto v1.6-release-24068

The code i've tried:

set("*test-resource.testSetting", "32")

<meta>
    <script src="server.lua" />
    <settings>
        <setting name="*testSetting" value="1" />
    </settings>
</meta>

And here as you can see below, works correctly because I've changed resource name to testresource (removed -)

[Elabyad247]

Thanks @omar-o22 , the screenshots helped a lot. When I first tried to reproduce I was only checking settings.xml, which looked correct, so I didn't see anything wrong. Once I saw you were checking the values through the admin panel, I tried that and I can reproduce it now with a resource named hello-mta: two rows show up for the same setting, and editing one of them writes a new entry like *hello-mta.hello-mta.testSetting to settings.xml instead of updating the existing one. It doesn't happen for a resource without a dash in the name.

From what I looked at so far and with some testing, the get/set functions seem fine, the bug looks like it's in the admin panel resource, specifically in aGetResourceSettings inside [admin]/admin/server/admin_settings.lua. It uses the resource name inside a pattern, and that seems to not work right when the name contains a -, which then makes the GUI show the setting twice and causes the duplicate entry when editing.

I'm still reading through the code to make sure I understand it fully and thinking about the best way to fix it and handle different potential cases and then share my thoughts.

[Elabyad247]

ok i figured it out and the fix looks simple. resName is being used inside a lua pattern so the dash is treated as a special character and based on the lua patterns reference, the standard way to handle this is to escape every special character with % before using the string as a pattern. once resName is escaped, the strip works correctly for any resource name. I tested it and it is working fine now.

Since the fix is in the admin panel resource and not in mtasa-blue itself, the PR should go to the mtasa-resources repo. @qaisjp , does that sound right to you?

[qaisjp]

Nice catch. That sounds right. We should also try to fix in admin2. Let me transfer this issue there.

[omar-o22]

Nice catch, btw the bug in admin2 so can you add admin2 label? @qaisjp