Skip to content

Commit ad74381

Browse files
author
Ruben
committed
rephrase isAscending/isDescending
In code it explicitely checks for asc and desc, so these elements will not work if `@attributeToSortParams` is set with different sorting values. Now this is more explicit
1 parent 22e2c8c commit ad74381

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -407,8 +407,8 @@ Various named blocks are offered, check your Ember Data Table design implementat
407407
- `nextSort` :: Next way of sorting. This is clear for
408408
`["asc","desc",""]` but users may have provided other sorting
409409
methods through `@attributeToSortParams`.
410-
- `isAscending` :: Are we sorting ascending now?
411-
- `isDescending` :: Are we sorting descending now?
410+
- `isAscending` :: Wether the current sorting is ascending (`'asc'`).
411+
- `isDescending` :: Wether the current sorting is descending (`'desc'`).
412412
- `sortDirection` :: What's the key on which we're sorting now (e.g.: `"desc"`)
413413
- `renderCustomBlock` :: Should a custom block be rendered for this data header?
414414
- `isCustom` :: Is the header explicitly marked to render custom?

0 commit comments

Comments
 (0)