Only recalculate stats of IntegrityError

Author: flodolo

pontoon/base/models/translated_resource.py

@@ -1,7 +1,7 @@
 import logging
 
 from django.db import models
-from django.db.models import Count, Q, Sum
+from django.db.models import Count, F, Q, Sum
 
 from .locale import Locale
 from .project import Project
@@ -114,6 +114,39 @@ def stats_data(self) -> dict[str, int]:
             "unreviewed": self.unreviewed_strings,
         }
 
+    def adjust_stats(
+        self, before: dict[str, int], after: dict[str, int], tr_created: bool
+    ):
+        if tr_created:
+            self.total_strings = self.resource.total_strings
+        self.approved_strings = (
+            F("approved_strings") + after["approved"] - before["approved"]
+        )
+        self.pretranslated_strings = (
+            F("pretranslated_strings")
+            + after["pretranslated"]
+            - before["pretranslated"]
+        )
+        self.strings_with_errors = (
+            F("strings_with_errors") + after["errors"] - before["errors"]
+        )
+        self.strings_with_warnings = (
+            F("strings_with_warnings") + after["warnings"] - before["warnings"]
+        )
+        self.unreviewed_strings = (
+            F("unreviewed_strings") + after["unreviewed"] - before["unreviewed"]
+        )
+        self.save(
+            update_fields=[
+                "total_strings",
+                "approved_strings",
+                "pretranslated_strings",
+                "strings_with_errors",
+                "strings_with_warnings",
+                "unreviewed_strings",
+            ]
+        )
+
     def calculate_stats(self, save=True):
         """Update stats, including denormalized ones."""
 

pontoon/base/models/translation.py

@@ -1,7 +1,7 @@
 from dirtyfields import DirtyFieldsMixin
 
 from django.contrib.postgres.fields import ArrayField
-from django.db import models
+from django.db import IntegrityError, models, transaction
 from django.db.models import Count, Q
 from django.utils import timezone
 
@@ -249,6 +249,8 @@ def save(self, failed_checks=None, *args, **kwargs):
         from pontoon.base.models.translated_resource import TranslatedResource
         from pontoon.base.models.translation_memory import TranslationMemoryEntry
 
+        stats_before = self._get_entity_stats()
+
         super().save(*args, **kwargs)
 
         project = self.entity.resource.project
@@ -320,7 +322,65 @@ def save(self, failed_checks=None, *args, **kwargs):
             save_failed_checks(self, failed_checks)
 
         # Update stats AFTER changing approval status.
-        translatedresource.calculate_stats()
+        # Use entity-scoped aggregate delta for performance. Fall back to a
+        # full resource recount on IntegrityError.
+        stats_after = self._get_entity_stats()
+        try:
+            with transaction.atomic():
+                translatedresource.adjust_stats(stats_before, stats_after, created)
+        except IntegrityError:
+            translatedresource.calculate_stats()
+
+    def _get_entity_stats(self) -> dict[str, int]:
+        """
+        Aggregate translation stats for this entity+locale pair.
+        Used to compute before/after deltas in save() without scanning
+        the entire resource.
+        """
+        stats = Translation.objects.filter(
+            entity=self.entity,
+            locale=self.locale,
+        ).aggregate(
+            approved_count=Count(
+                "pk",
+                filter=Q(approved=True, errors__isnull=True, warnings__isnull=True),
+            ),
+            pretranslated_count=Count(
+                "pk",
+                filter=Q(
+                    pretranslated=True, errors__isnull=True, warnings__isnull=True
+                ),
+            ),
+            errors_count=Count(
+                "pk",
+                distinct=True,
+                filter=Q(
+                    Q(Q(approved=True) | Q(pretranslated=True) | Q(fuzzy=True))
+                    & Q(errors__isnull=False)
+                ),
+            ),
+            warnings_count=Count(
+                "pk",
+                distinct=True,
+                filter=Q(
+                    Q(Q(approved=True) | Q(pretranslated=True) | Q(fuzzy=True))
+                    & Q(warnings__isnull=False)
+                ),
+            ),
+            unreviewed_count=Count(
+                "pk",
+                filter=Q(
+                    approved=False, rejected=False, pretranslated=False, fuzzy=False
+                ),
+            ),
+        )
+        return {
+            "approved": stats["approved_count"],
+            "pretranslated": stats["pretranslated_count"],
+            "errors": stats["errors_count"],
+            "warnings": stats["warnings_count"],
+            "unreviewed": stats["unreviewed_count"],
+        }
 
     def update_latest_translation(self):
         """

translate/public/locale/en-US/translate.ftl

@@ -570,6 +570,7 @@ notification--translation-unrejected = Translation unrejected
 notification--translation-deleted = Translation deleted
 notification--translation-saved = Translation saved
 notification--unable-to-approve-translation = Unable to approve translation
+notification--unable-to-save-translation = Unable to save translation
 notification--unable-to-unapprove-translation = Unable to unapprove translation
 notification--unable-to-reject-translation = Unable to reject translation
 notification--unable-to-unreject-translation = Unable to unreject translation

translate/src/modules/editor/hooks/useSendTranslation.ts

@@ -18,6 +18,7 @@ import { usePushNextTranslatable } from '~/modules/entities/hooks';
 import {
   SAME_TRANSLATION,
   TRANSLATION_SAVED,
+  UNABLE_TO_SAVE_TRANSLATION,
 } from '~/modules/notification/messages';
 import { updateResource } from '~/modules/resource/actions';
 import { updateStats } from '~/modules/stats/actions';
@@ -109,6 +110,8 @@ export function useSendTranslation(): (ignoreWarnings?: boolean) => void {
       // The translation that was provided is the same as an existing
       // translation for that entity.
       showNotification(SAME_TRANSLATION);
+    } else {
+      showNotification(UNABLE_TO_SAVE_TRANSLATION);
     }
 
     setEditorBusy(false);

translate/src/modules/notification/messages.tsx

@@ -57,6 +57,15 @@ export const TRANSLATION_SAVED: NotificationMessage = {
   type: 'info',
 };
 
+export const UNABLE_TO_SAVE_TRANSLATION: NotificationMessage = {
+  content: (
+    <Localized id='notification--unable-to-save-translation'>
+      Unable to save translation
+    </Localized>
+  ),
+  type: 'error',
+};
+
 export const UNABLE_TO_APPROVE_TRANSLATION: NotificationMessage = {
   content: (
     <Localized id='notification--unable-to-approve-translation'>