Blackscreen using 1.6.5 on waveshare esp32 3.5

[gopro2027]

Device: https://www.waveshare.com/esp32-s3-touch-lcd-3.5.htm?sku=30733

My last working build was on version 1.5.5 of the gfx library and an older version of arduino core as you can see here: https://github.com/gopro2027/ArduinoAirSuspensionController/blob/7f336db7377207c8b894c6bad6453cf4ccb69b93/Wireless_Controller/device_libs/ws3p5/library.json

I am now using this for my platform https://github.com/pioarduino/platform-espressif32/releases/download/55.03.37/platform-espressif32.zip which is the latest release of pioarduino/platform-espressif32

I was able to get the full screen working properly again by reverting to release 55.03.31-2 and arduino gfx 1.5.5, and my screen then worked again.

I then updated arduino gfx to 1.6.5 and kept that older release, and now it blackscreens again.

So I can confirm the issue is somewhere in the arduino gfx library between 1.5.5 and 1.6.5 causing a blackscreen on this device.

[gopro2027]

1.6.0 also does not work
1.5.7 also does not work
1.5.6 also does not work
So it does seem 1.5.5 is the last working version for this device.
Something in 1.5.6 broke this device.

[gopro2027]

AI analysis:

Says in 1.5.6 you force SPI_MODE3 in Arduino_ST7796::begin but in 1.5.5 it is SPI_MODE0. Does this sound like it's on track?

[gopro2027]

I was able to confirm the AI was correct. It is this function here: https://github.com/moononournation/Arduino_GFX/blob/master/src/display/Arduino_ST7796.cpp#L16

My device wants SPI_MODE0 but it is loading MODE3

I was able to override this override to be mode 0 and it worked.

[gopro2027]

Created pr #789