Merge dev to main: Linear router resolveProject fix#1338
Merged
Conversation
Co-authored-by: Cascade Bot <bot@cascade.dev>
Co-authored-by: Cascade Bot <bot@cascade.dev>
Co-authored-by: Cascade Bot <bot@cascade.dev>
… miss) PR #1332 fixed `parseWebhook` to select the right cascade project by team + Linear-Project scope, but missed `resolveProject` at the same file (line 227-230) which re-looks up by `event.projectIdentifier` (the teamId) and uses the same `.find()` first-match pattern. Live evidence from 2026-05-11 prod: webhook ddcee404 body had `data.projectId: 7108c72e-...` (ucho scope); run d58cd8ab dispatched with projectId=cascade, cloned mongrel-intelligence/cascade. Agent correctly identified the workspace/work-item mismatch and filed a friction report. Fix: resolveProject uses event.projectId (cascade project id parseWebhook already determined) when present, falling back to teamId lookup only for legacy bare-event callers. Audit of all .find() shadow sites — only Linear resolveProject needed fixing. webhookVerification.ts Linear lookup is harmless because Linear webhook secrets are team-scoped. findProjectByLinearTeamId is dead code. JIRA / Trello / GitHub adapters have naturally unique-per-cascade-project discriminators. Tests: extended resolveProject describe block with multi-cascade-project- per-team sub-describe covering: returns ucho regardless of array order, returns cascade for cascade events, null fail-closed when projectId is unconfigured, and legacy bare-event teamId-fallback compat. All 49 LinearRouterAdapter tests pass; full suite (9307 unit tests) clean. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…resolveProject-shadow fix(router): use event.projectId in Linear resolveProject (closes #1332 miss)
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code