fix(ci): stream coverage comment payloads

Author: yiliang114

.github/scripts/upsert-bot-comment.sh

@@ -33,7 +33,9 @@ marker="${3:?missing marker}"
 body_file="${4:?missing body file}"
 update_only="${5:-}"
 
-body="$(cat "${body_file}")"
+comment_payload() {
+  jq -n --rawfile body "${body_file}" '{body: $body}'
+}
 
 for _attempt in 1 2 3; do
   if bot_login="${BOT_LOGIN:-}" \
@@ -49,17 +51,18 @@ for _attempt in 1 2 3; do
           | select((.body // "") | contains($marker))]
         | last | .id // empty')"; then
     if [ -n "${existing_id}" ]; then
-      if gh api --method PATCH \
+      if comment_payload | gh api --method PATCH \
         "repos/${repo}/issues/comments/${existing_id}" \
-        -f body="${body}" >/dev/null; then
+        --input - >/dev/null; then
         echo "updated comment ${existing_id}"
         exit 0
       fi
     elif [ "${update_only}" = "--update-only" ]; then
       echo "no existing comment; nothing to update"
       exit 0
-    elif gh api "repos/${repo}/issues/${number}/comments" \
-      -f body="${body}" >/dev/null; then
+    elif comment_payload | gh api --method POST \
+      "repos/${repo}/issues/${number}/comments" \
+      --input - >/dev/null; then
       echo "posted new comment"
       exit 0
     fi

.github/scripts/upsert-bot-comment.test.mjs

@@ -31,14 +31,17 @@ const here = dirname(fileURLToPath(import.meta.url));
 const script = join(here, 'upsert-bot-comment.sh');
 const MARKER = '<!-- test-marker -->';
 
-function run(scenario, { updateOnly = false, botLogin = '' } = {}) {
+function run(
+  scenario,
+  { updateOnly = false, botLogin = '', body = `${MARKER}\nhello` } = {},
+) {
   const dir = mkdtempSync(join(tmpdir(), 'upsert-bot-comment-'));
   const bin = join(dir, 'bin');
   mkdirSync(bin);
   const calls = join(dir, 'calls');
   writeFileSync(calls, '');
   const bodyFile = join(dir, 'body');
-  writeFileSync(bodyFile, `${MARKER}\nhello`);
+  writeFileSync(bodyFile, body);
   const write = (name, body) => {
     writeFileSync(join(bin, name), body);
     chmodSync(join(bin, name), 0o755);
@@ -49,6 +52,7 @@ function run(scenario, { updateOnly = false, botLogin = '' } = {}) {
     [
       '#!/bin/bash',
       'echo "$*" >> "$CALLS"',
+      'if [[ "$*" == *"--input -"* ]]; then cat >/dev/null; fi',
       'n=$(grep -c "method GET" "$CALLS" || true)',
       'case "$*" in',
       '  "api user"*)',
@@ -120,6 +124,15 @@ test('uses BOT_LOGIN when the token cannot access /user', () => {
   assert.doesNotMatch(r.calls, /api user/);
 });
 
+test('streams large comment bodies through stdin', () => {
+  const r = run('fresh', {
+    body: `${MARKER}\n${'x'.repeat(200_000)}`,
+  });
+  assert.equal(r.code, 0);
+  assert.match(r.calls, /--method POST .* --input -/);
+  assert.doesNotMatch(r.calls, /body=/);
+});
+
 test('PATCHes the existing bot-authored marker comment', () => {
   const r = run('existing-bot');
   assert.equal(r.code, 0);
@@ -149,7 +162,7 @@ test('--update-only is a no-op success when nothing exists', () => {
   assert.match(r.stdout, /nothing to update/);
   assert.doesNotMatch(r.calls, /--method PATCH/);
   // And no POST either: the only api writes would be comment creation.
-  assert.doesNotMatch(r.calls, /issues\/42\/comments -f/);
+  assert.doesNotMatch(r.calls, /--method POST/);
 });
 
 test('a failed listing NEVER falls through to POST (retries, then PATCHes)', () => {
@@ -159,7 +172,7 @@ test('a failed listing NEVER falls through to POST (retries, then PATCHes)', ()
   const r = run('listing-fails-once');
   assert.equal(r.code, 0);
   assert.match(r.stdout, /updated comment 7/);
-  assert.doesNotMatch(r.calls, /issues\/42\/comments -f/);
+  assert.doesNotMatch(r.calls, /--method POST/);
 });
 
 test('a persistently failing identity lookup exits 1 without writing', () => {

.github/workflows/ci.yml

@@ -944,6 +944,7 @@ jobs:
           path: 'coverage_artifact' # Download to a specific directory
 
       - name: 'Post Coverage Comment using Composite Action'
+        continue-on-error: true
         uses: './.github/actions/post-coverage-comment' # Path to the composite action directory
         with:
           cli_json_file: 'coverage_artifact/cli/coverage/coverage-summary.json'