From afb7046584f24b0d46c4c9d639acc8ca085f3c7c Mon Sep 17 00:00:00 2001 From: Luca Secchieri Date: Sat, 28 Mar 2026 17:14:24 +0100 Subject: [PATCH 1/2] fix: correct typo and mismatched godoc comment names Fix a typo in schema/example_test.go where "incercept" was misspelled (should be "intercept"). Fix godoc comments in specs-go/v1/mediatype.go where three weight config constants (MediaTypeModelWeightConfig, MediaTypeModelWeightConfigGzip, MediaTypeModelWeightConfigZstd) had comments referencing the wrong names (MediaTypeModelConfig, MediaTypeModelConfigGzip, MediaTypeModelConfigZstd). Signed-off-by: Luca Secchieri --- schema/example_test.go | 2 +- specs-go/v1/mediatype.go | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/schema/example_test.go b/schema/example_test.go index d179e4f..67661cc 100644 --- a/schema/example_test.go +++ b/schema/example_test.go @@ -72,7 +72,7 @@ func validate(t *testing.T, name string) { } } -// renderer allows one to incercept fenced blocks in markdown documents. +// renderer allows one to intercept fenced blocks in markdown documents. type renderer struct { blackfriday.Renderer fn func(text []byte, lang string) diff --git a/specs-go/v1/mediatype.go b/specs-go/v1/mediatype.go index 63c9f83..c904829 100644 --- a/specs-go/v1/mediatype.go +++ b/specs-go/v1/mediatype.go @@ -40,13 +40,13 @@ const ( // MediaTypeModelWeightConfigRaw is the media type used for an unarchived, uncompressed model weights, including files like `tokenizer.json`, `config.json`, etc. MediaTypeModelWeightConfigRaw = "application/vnd.cncf.model.weight.config.v1.raw" - // MediaTypeModelConfig specifies the media type for configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. + // MediaTypeModelWeightConfig specifies the media type for configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. MediaTypeModelWeightConfig = "application/vnd.cncf.model.weight.config.v1.tar" - // MediaTypeModelConfigGzip specifies the media type for gzipped configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. + // MediaTypeModelWeightConfigGzip specifies the media type for gzipped configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. MediaTypeModelWeightConfigGzip = "application/vnd.cncf.model.weight.config.v1.tar+gzip" - // MediaTypeModelConfigZstd specifies the media type for zstd compressed configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. + // MediaTypeModelWeightConfigZstd specifies the media type for zstd compressed configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. MediaTypeModelWeightConfigZstd = "application/vnd.cncf.model.weight.config.v1.tar+zstd" // MediaTypeModelDocRaw is the media type used for an unarchived, uncompressed model documentation, including documentation files like `README.md`, `LICENSE`, etc. From 7e558a12074028a3bc08f61a4a762a1de00ae00d Mon Sep 17 00:00:00 2001 From: Luca Secchieri Date: Sun, 29 Mar 2026 20:53:37 +0200 Subject: [PATCH 2/2] fix(specs-go): clarify godoc comments for MediaTypeModelWeightConfig constants Remove `config.json` from the example files in MediaTypeModelWeightConfig* comments to avoid confusion with the ModelPack artifact config (application/vnd.cncf.model.config.v1+json) defined in docs/config.md. Also fix the description in MediaTypeModelWeightConfigRaw which incorrectly referred to "model weights" instead of "configuration of the model weights". Signed-off-by: Luca Secchieri --- specs-go/v1/mediatype.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/specs-go/v1/mediatype.go b/specs-go/v1/mediatype.go index c904829..450cdf7 100644 --- a/specs-go/v1/mediatype.go +++ b/specs-go/v1/mediatype.go @@ -37,16 +37,16 @@ const ( // MediaTypeModelWeightZstd is the media type used for zstd compressed model weights. MediaTypeModelWeightZstd = "application/vnd.cncf.model.weight.v1.tar+zstd" - // MediaTypeModelWeightConfigRaw is the media type used for an unarchived, uncompressed model weights, including files like `tokenizer.json`, `config.json`, etc. + // MediaTypeModelWeightConfigRaw is the media type used for an unarchived, uncompressed configuration of the model weights, including files like `tokenizer.json`, etc. MediaTypeModelWeightConfigRaw = "application/vnd.cncf.model.weight.config.v1.raw" - // MediaTypeModelWeightConfig specifies the media type for configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. + // MediaTypeModelWeightConfig specifies the media type for configuration of the model weights, including files like `tokenizer.json`, etc. MediaTypeModelWeightConfig = "application/vnd.cncf.model.weight.config.v1.tar" - // MediaTypeModelWeightConfigGzip specifies the media type for gzipped configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. + // MediaTypeModelWeightConfigGzip specifies the media type for gzipped configuration of the model weights, including files like `tokenizer.json`, etc. MediaTypeModelWeightConfigGzip = "application/vnd.cncf.model.weight.config.v1.tar+gzip" - // MediaTypeModelWeightConfigZstd specifies the media type for zstd compressed configuration of the model weights, including files like `tokenizer.json`, `config.json`, etc. + // MediaTypeModelWeightConfigZstd specifies the media type for zstd compressed configuration of the model weights, including files like `tokenizer.json`, etc. MediaTypeModelWeightConfigZstd = "application/vnd.cncf.model.weight.config.v1.tar+zstd" // MediaTypeModelDocRaw is the media type used for an unarchived, uncompressed model documentation, including documentation files like `README.md`, `LICENSE`, etc.