-
Notifications
You must be signed in to change notification settings - Fork 1.8k
bug: invalid types for sessionIdGenerator in 1.25.2 #1397
Copy link
Copy link
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featurebugSomething isn't workingSomething isn't workingfix proposedBot has a verified fix diff in the commentBot has a verified fix diff in the commentready for workEnough information for someone to start working onEnough information for someone to start working on
Metadata
Metadata
Assignees
Labels
P2Moderate issues affecting some users, edge cases, potentially valuable featureModerate issues affecting some users, edge cases, potentially valuable featurebugSomething isn't workingSomething isn't workingfix proposedBot has a verified fix diff in the commentBot has a verified fix diff in the commentready for workEnough information for someone to start working onEnough information for someone to start working on
SDK 1.25.2 introduced types that break projects using
sessionIdGenerator: undefinedwith strict TypeScript configs.Errors
Cause
Optional properties like
sessionIdGenerator?: () => stringneed to be typed assessionIdGenerator?: (() => string) | undefinedto allow explicitly passingundefined.Similarly, the
Transportinterface'soncloseproperty needs the same treatment.I beleive this was recently changed in #1326