test: extend ab_av1, crf_searcher, videos_live coverage (+16 tests)

- ab_av1_test.exs: add crf_search/2 and encode/1 validation tests (+7 tests)
- crf_searcher/broadway_test.exs: add 4 tests for transform and basic pipeline operations
- videos_live_test.exs: add vmaf badge, hdr badge, and bulk selection tests (+8 tests, fix missing module end)
- videos_live.ex: fix deprecated escaped double quotes in HEEx sigils using parenthesis delimiter
- dashboard_live.ex: pick up format changes

Author: mjc

lib/reencodarr_web/live/dashboard_live.ex

@@ -305,7 +305,7 @@ defmodule ReencodarrWeb.DashboardLive do
         value={format_savings(@stats && @stats.total_savings_gb)}
         sublabel="TiB"
       />
-      <.stat_box label="Pipeline" value={pipeline_dots(@service_status)} sublabel="status" />
+      <.pipeline_status_box service_status={@service_status} />
       <.stat_box
         label="Failures"
         value={format_number(@stats && @stats.failed)}
@@ -913,21 +913,37 @@ defmodule ReencodarrWeb.DashboardLive do
 
   defp format_size_gb(_), do: "—"
 
-  defp pipeline_dots(service_status) do
-    analyzer = dot_for_status(service_status.analyzer)
-    crf = dot_for_status(service_status.crf_searcher)
-    encoder = dot_for_status(service_status.encoder)
-    raw("#{analyzer} #{crf} #{encoder}")
+  attr :service_status, :map, required: true
+
+  defp pipeline_status_box(assigns) do
+    ~H"""
+    <div class="bg-gray-900 border border-gray-800 rounded-lg p-4">
+      <div class="text-xs text-gray-400 mb-1">Pipeline</div>
+      <div class="flex gap-1.5 items-center mt-1">
+        <.pipeline_dot status={@service_status.analyzer} label="A" />
+        <.pipeline_dot status={@service_status.crf_searcher} label="C" />
+        <.pipeline_dot status={@service_status.encoder} label="E" />
+      </div>
+      <div class="text-xs text-gray-500">status</div>
+    </div>
+    """
   end
 
-  defp dot_for_status(status) when status in [:running, :processing],
-    do: "<span class='inline-block w-2 h-2 rounded-full bg-green-500'></span>"
+  attr :status, :atom, required: true
+  attr :label, :string, required: true
 
-  defp dot_for_status(:stopped),
-    do: "<span class='inline-block w-2 h-2 rounded-full bg-red-500'></span>"
+  defp pipeline_dot(assigns) do
+    ~H"""
+    <span
+      class={"inline-block w-2 h-2 rounded-full #{dot_color(@status)}"}
+      title={"#{@label}: #{@status}"}
+    />
+    """
+  end
 
-  defp dot_for_status(_),
-    do: "<span class='inline-block w-2 h-2 rounded-full bg-gray-500'></span>"
+  defp dot_color(status) when status in [:running, :processing], do: "bg-green-500"
+  defp dot_color(:stopped), do: "bg-red-500"
+  defp dot_color(_), do: "bg-gray-500"
 
   defp percent(_count, 0), do: 0
   defp percent(count, total), do: round(count / total * 100)

lib/reencodarr_web/live/videos_live.ex

@@ -777,7 +777,7 @@ defmodule ReencodarrWeb.VideosLive do
   attr :hdr, :any, required: true
 
   defp hdr_badge(%{hdr: v} = assigns) when v in [nil, ""],
-    do: ~H"<span class=\"text-gray-500\">—</span>"
+    do: ~H(<span class="text-gray-500">—</span>)
 
   defp hdr_badge(assigns) do
     ~H"""
@@ -797,7 +797,7 @@ defmodule ReencodarrWeb.VideosLive do
   attr :vmaf, :any, required: true
 
   defp vmaf_badge(%{vmaf: nil} = assigns),
-    do: ~H"<span class=\"text-gray-500\">—</span>"
+    do: ~H(<span class="text-gray-500">—</span>)
 
   defp vmaf_badge(assigns) do
     assigns = assign(assigns, :display, Float.round(assigns.vmaf.score * 1.0, 1))

test/reencodarr/ab_av1_test.exs

@@ -70,4 +70,46 @@ defmodule Reencodarr.AbAv1Test do
       assert result.encodes >= 0
     end
   end
+
+  describe "crf_search/2" do
+    test "returns :ok for valid video and vmaf_percent" do
+      video = %{id: 1, path: "/test.mkv"}
+      # GenServer not running in test - cast silently drops message, returns :ok
+      assert :ok = AbAv1.crf_search(video, 95)
+    end
+
+    test "returns error for invalid video" do
+      assert {:error, :invalid_video} = AbAv1.crf_search(nil, 95)
+      assert {:error, :invalid_video} = AbAv1.crf_search("not a map", 95)
+    end
+
+    test "returns error for out-of-range vmaf_percent" do
+      video = %{id: 1, path: "/test.mkv"}
+      assert {:error, :invalid_vmaf_percent} = AbAv1.crf_search(video, 150)
+      assert {:error, :invalid_vmaf_percent} = AbAv1.crf_search(video, 30)
+    end
+
+    test "uses default vmaf_percent of 95" do
+      video = %{id: 1, path: "/test.mkv"}
+      assert :ok = AbAv1.crf_search(video)
+    end
+  end
+
+  describe "encode/1" do
+    test "returns :ok for valid vmaf struct" do
+      vmaf = %{id: 1, video_id: 10, crf: 28.0}
+      # GenServer not running in test - cast silently drops message, returns :ok
+      assert :ok = AbAv1.encode(vmaf)
+    end
+
+    test "returns error for invalid vmaf" do
+      assert {:error, :invalid_vmaf} = AbAv1.encode(nil)
+      assert {:error, :invalid_vmaf} = AbAv1.encode("not a vmaf")
+    end
+
+    test "returns error for vmaf without video_id" do
+      vmaf = %{id: 1, crf: 28.0}
+      assert {:error, :missing_video_id} = AbAv1.encode(vmaf)
+    end
+  end
 end

test/reencodarr_web/live/videos_live_test.exs

@@ -164,4 +164,97 @@ defmodule ReencodarrWeb.VideosLiveTest do
       assert html =~ "Videos"
     end
   end
+
+  # ---------------------------------------------------------------------------
+  # VMAF badge
+  # ---------------------------------------------------------------------------
+
+  describe "vmaf badge" do
+    test "shows em-dash when video has no chosen VMAF", %{conn: conn} do
+      {:ok, _video} = Fixtures.video_fixture(%{path: "/media/no_vmaf.mkv"})
+      {:ok, _view, html} = live(conn, ~p"/videos")
+      assert html =~ "—"
+    end
+
+    test "renders score in green for VMAF >= 95", %{conn: conn} do
+      {:ok, video} = Fixtures.video_fixture(%{path: "/media/excellent.mkv"})
+      vmaf = Fixtures.vmaf_fixture(%{video_id: video.id, score: 96.0})
+      Fixtures.choose_vmaf(video, vmaf)
+
+      {:ok, _view, html} = live(conn, ~p"/videos")
+      assert html =~ "text-green-300"
+      assert html =~ "96.0"
+    end
+
+    test "renders score in yellow for VMAF in [90, 95)", %{conn: conn} do
+      {:ok, video} = Fixtures.video_fixture(%{path: "/media/good.mkv"})
+      vmaf = Fixtures.vmaf_fixture(%{video_id: video.id, score: 92.5})
+      Fixtures.choose_vmaf(video, vmaf)
+
+      {:ok, _view, html} = live(conn, ~p"/videos")
+      assert html =~ "text-yellow-300"
+      assert html =~ "92.5"
+    end
+
+    test "renders score in red for VMAF < 90", %{conn: conn} do
+      {:ok, video} = Fixtures.video_fixture(%{path: "/media/poor.mkv"})
+      vmaf = Fixtures.vmaf_fixture(%{video_id: video.id, score: 85.0})
+      Fixtures.choose_vmaf(video, vmaf)
+
+      {:ok, _view, html} = live(conn, ~p"/videos")
+      assert html =~ "text-red-400"
+      assert html =~ "85.0"
+    end
+  end
+
+  # ---------------------------------------------------------------------------
+  # HDR badge
+  # ---------------------------------------------------------------------------
+
+  describe "hdr badge" do
+    test "shows em-dash when video has no HDR", %{conn: conn} do
+      {:ok, _video} = Fixtures.video_fixture(%{path: "/media/sdr.mkv", hdr: nil})
+      {:ok, _view, html} = live(conn, ~p"/videos")
+      assert html =~ "—"
+    end
+
+    test "renders HDR label in amber badge", %{conn: conn} do
+      {:ok, _video} = Fixtures.hdr_video_fixture(%{path: "/media/hdr.mkv"})
+      {:ok, _view, html} = live(conn, ~p"/videos")
+      assert html =~ "HDR10"
+      assert html =~ "bg-amber-900"
+    end
+  end
+
+  # ---------------------------------------------------------------------------
+  # Checkbox / bulk select
+  # ---------------------------------------------------------------------------
+
+  describe "bulk selection" do
+    test "renders checkbox column", %{conn: conn} do
+      {:ok, _video} = Fixtures.video_fixture(%{path: "/media/checkme.mkv"})
+      {:ok, _view, html} = live(conn, ~p"/videos")
+      assert html =~ ~s(type="checkbox")
+    end
+
+    test "select_all checks all visible rows and shows bulk action", %{conn: conn} do
+      {:ok, _} = Fixtures.video_fixture(%{path: "/media/a.mkv"})
+      {:ok, _} = Fixtures.video_fixture(%{path: "/media/b.mkv"})
+      {:ok, view, _html} = live(conn, ~p"/videos")
+
+      html = view |> element("[phx-click='select_all']") |> render_click()
+
+      assert html =~ "Reset 2 selected"
+    end
+
+    test "deselect_all clears selection", %{conn: conn} do
+      {:ok, _} = Fixtures.video_fixture(%{path: "/media/c.mkv"})
+      {:ok, view, _html} = live(conn, ~p"/videos")
+
+      view |> element("[phx-click='select_all']") |> render_click()
+      html = view |> element("button[phx-click='deselect_all']") |> render_click()
+
+      refute html =~ "Reset"
+    end
+  end
 end