|
Builder &SetId(int id) { id_ = id; return *this; } |
|
Builder &SetAircraftId(const std::string &aircraft_id) { |
|
id_ = mitre::oss::simcore::ScenarioUtils::GetUniqueIdForAircraftId(aircraft_id); |
|
return *this; |
|
} |
These lines show confusion. There should not be both integer id and string id. And string id is paramount. Attempt to fully remove the interger concept from the codebase, retaining the string. If there is code that uses the interger and is not easily refactored away, then use ScenarioUtils to handle that.
im_sample_algorithm/include/imalgs/FIMAircraftIntent.h
Lines 38 to 42 in d7b5a8e
These lines show confusion. There should not be both integer id and string id. And string id is paramount. Attempt to fully remove the interger concept from the codebase, retaining the string. If there is code that uses the interger and is not easily refactored away, then use
ScenarioUtilsto handle that.