Skip to content

Clean up builder interaction #15

Description

@sbowman-mitre

Builder &SetId(int id) { id_ = id; return *this; }
Builder &SetAircraftId(const std::string &aircraft_id) {
id_ = mitre::oss::simcore::ScenarioUtils::GetUniqueIdForAircraftId(aircraft_id);
return *this;
}

These lines show confusion. There should not be both integer id and string id. And string id is paramount. Attempt to fully remove the interger concept from the codebase, retaining the string. If there is code that uses the interger and is not easily refactored away, then use ScenarioUtils to handle that.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions