refactor: harden feature install scripts#66
Open
mikaello wants to merge 2 commits into
Open
Conversation
`uname -m` on Linux returns `x86_64` or `aarch64`; `amd64` and `arm64` are dpkg / macOS spellings that the kernel never produces, so those branches were dead.
- Renumber "Step 4.5" / "Step 5" to "Step 5" / "Step 6" so the trace reads sequentially. - Use `ln -sf` so re-running the script (e.g. after rebuild on top of an existing layer) replaces the symlinks instead of failing on "File exists".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
amd64/arm64branches from the architecture check in bothkotlincandmodern-shell-utils.uname -mon Linux returnsx86_64oraarch64; the dpkg/macOS spellings can never match.modern-shell-utilssteps so the trace readsStep 1..Step 6instead of aStep 4.5interlude.ln -sffor thefd/batsymlinks so re-running the script does not fail with "File exists" when those symlinks already exist (e.g. when the feature is rebuilt over an existing layer).Test plan
test.yamlruns both features ondebian:latest,ubuntu:latest, andmcr.microsoft.com/devcontainers/base:ubuntuand the per-featuretest.shchecks pass.aarch64is preserved).