Make SteamAPI intialization more robust

Author: mmusu3

SEToolbox/Interop/SpaceEngineersCore.cs

@@ -17,6 +17,7 @@
     using SEToolbox.Models;
     using SEToolbox.Support;
     using SpaceEngineers.Game;
+    using Steamworks;
     using VRage;
     using VRage.Collections;
     using VRage.FileSystem;
@@ -111,7 +112,7 @@ public SpaceEngineersCore()
             // This will start the Steam Service, and Steam will think SE is running.
             // TODO: we don't want to be doing this all the while SEToolbox is running,
             // perhaps a once off during load to fetch of mods then disconnect/Dispose.
-            _steamService = MySteamGameService.Create(Sandbox.Engine.Platform.Game.IsDedicated, AppId);
+            _steamService = CreateSteamService();
             MyServiceManager.Instance.AddService(_steamService);
 
             Log.Debug("Init VRage platform.");
@@ -194,6 +195,81 @@ public SpaceEngineersCore()
             _manageDeleteVoxelList = [];
         }
 
+        // Re-implement most of MySteamService constructor (with adjustments) to
+        // bypass the call to Environment.Exit
+        static IMyGameService CreateSteamService()
+        {
+            //return MySteamGameService.Create(Sandbox.Engine.Platform.Game.IsDedicated, AppId);
+
+            var appIdStr = AppId.ToString();
+            Environment.SetEnvironmentVariable("SteamAppId", appIdStr);
+            Environment.SetEnvironmentVariable("SteamGameId", appIdStr);
+
+            // isDedicated: true skips the initialization that is done here instead.
+            var service = MySteamGameService.Create(isDedicated: true, AppId);
+            var serviceType = service.GetType();
+
+            var steamAppId = (AppId_t)AppId;
+
+            //if (SteamAPI.RestartAppIfNecessary(steamAppId))
+            //    Log.Error("SteamAPI.RestartAppIfNecessary returned true.");
+
+            bool isActive = SteamAPI.Init();
+            serviceType.GetProperty("IsActive").SetValue(service, isActive);
+
+            if (!isActive)
+                Log.Error("Failed to initialize Steam service.");
+
+            IMyInventoryService serviceInstance;
+
+            const ulong OFFLINE_STEAM_ID = 1234567891011uL;
+
+            if (isActive)
+            {
+                var steamUserId = SteamUser.GetSteamID();
+                service.UserId = (ulong)steamUserId;
+
+                var userName = "\ue030" + SteamFriends.GetPersonaName();
+                var hasLicenseResult = SteamUser.UserHasLicenseForApp(steamUserId, steamAppId);
+                bool ownsGame = hasLicenseResult == EUserHasLicenseForAppResult.k_EUserHasLicenseResultHasLicense;
+                var userUniverse = (MyGameServiceUniverse)SteamUtils.GetConnectedUniverse();
+                var branchName = SteamApps.GetCurrentBetaName(out var pchName, 512) ? pchName : "default";
+
+                serviceType.GetField("SteamUserId", BindingFlags.Instance | BindingFlags.NonPublic).SetValue(service, steamUserId);
+                serviceType.GetProperty("UserName").SetValue(service, userName);
+                serviceType.GetProperty("OwnsGame").SetValue(service, ownsGame);
+                serviceType.GetProperty("UserUniverse").SetValue(service, userUniverse);
+                serviceType.GetProperty("BranchName").SetValue(service, branchName);
+
+                SteamUserStats.RequestCurrentStats();
+                serviceType.GetMethod("RegisterCallbacks", BindingFlags.Instance | BindingFlags.NonPublic).Invoke(service, []);
+
+                var remoteStorage = Activator.CreateInstance(Type.GetType("VRage.Steam.MySteamRemoteStorage, VRage.Steam"));
+
+                serviceType.GetField("m_remoteStorage", BindingFlags.Instance | BindingFlags.NonPublic).SetValue(service, remoteStorage);
+
+                serviceInstance = (IMyInventoryService)Activator.CreateInstance(Type.GetType("VRage.Steam.MySteamInventory, VRage.Steam"), [service]);
+            }
+            else
+            {
+                service.UserId = OFFLINE_STEAM_ID;
+                serviceInstance = new MyNullInventoryService();
+            }
+
+            MyServiceManager.Instance.AddService(serviceInstance);
+
+            if (!isActive)
+            {
+                var errMsg = """
+                    Failed to initialize Steam API. Please ensure Steam is running and re-launch SEToolbox.
+                    You can try to continue anyway but modded worlds may not work correctly.
+                    """;
+                MessageBox.Show(errMsg, "Error", MessageBoxButtons.OK, MessageBoxIcon.Error);
+            }
+
+            return service;
+        }
+
         static void InitMultithreading()
         {
             //MySandboxGame.InitMultithreading();

SEToolbox/Interop/SpaceEngineersWorkshop.cs

@@ -14,6 +14,9 @@ public class SpaceEngineersWorkshop
     {
         public static MyWorkshop.ResultData DownloadWorldModsBlocking(List<MyObjectBuilder_Checkpoint.ModItem> mods, MyWorkshop.CancelToken cancelToken)
         {
+            if (!MyGameService.IsActive)
+                return default;
+
             MyWorkshop.ResultData ret = default;
 
             Task task = Parallel.Start(() =>

SEToolbox/Models/WorldResource.cs

@@ -287,9 +287,13 @@ public void LoadDefinitionsAndMods()
             if (_resources == null || Checkpoint == null || Checkpoint.Mods == null)
                 return;
 
-            SpaceEngineersWorkshop.DownloadWorldModsBlocking(Checkpoint.Mods, cancelToken: null);
+            List<MyObjectBuilder_Checkpoint.ModItem> mods = [.. Checkpoint.Mods];
+            var result = SpaceEngineersWorkshop.DownloadWorldModsBlocking(mods, cancelToken: null);
 
-            _resources.LoadDefinitionsAndMods(DataPath.ModsPath, Checkpoint.Mods);
+            if (result.Result == 0)
+                mods.Clear();
+
+            _resources.LoadDefinitionsAndMods(DataPath.ModsPath, mods);
         }
 
         public bool LoadSector(out string errorInformation, bool snapshot = false)

SEToolbox/SEToolbox.csproj

@@ -125,9 +125,6 @@
       <Link>VRage.Native.dll</Link>
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </Content>
-    <None Include="steam_appid.txt">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
   </ItemGroup>
 
   <ItemGroup>