-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Expand file tree
/
Copy pathManifestSchemaValidation.cpp
More file actions
453 lines (396 loc) · 21.2 KB
/
ManifestSchemaValidation.cpp
File metadata and controls
453 lines (396 loc) · 21.2 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
// Copyright (c) Microsoft Corporation.
// Licensed under the MIT License.
#include "pch.h"
#include "winget/Yaml.h"
#include "winget/JsonSchemaValidation.h"
#include "winget/ManifestCommon.h"
#include "winget/ManifestSchemaValidation.h"
#include "winget/ManifestYamlParser.h"
#include "winget/Resources.h"
#include <ManifestSchema.h>
namespace AppInstaller::Manifest::YamlParser
{
using namespace std::string_view_literals;
namespace
{
enum class YamlScalarType
{
String,
Int,
Bool
};
// List of fields that use non string scalar types
const std::map<std::string_view, YamlScalarType> ManifestFieldTypes =
{
{ "InstallerSuccessCodes"sv, YamlScalarType::Int },
{ "InstallerAbortsTerminal"sv, YamlScalarType::Bool },
{ "InstallLocationRequired"sv, YamlScalarType::Bool },
{ "RequireExplicitUpgrade"sv, YamlScalarType::Bool },
{ "DisplayInstallWarnings"sv, YamlScalarType::Bool },
{ "InstallerReturnCode"sv, YamlScalarType::Int },
{ "DownloadCommandProhibited", YamlScalarType::Bool },
{ "ArchiveBinariesDependOnPath", YamlScalarType::Bool },
{ "UninstallerSuccessCodes"sv, YamlScalarType::Int },
};
YamlScalarType GetManifestScalarValueType(const std::string& key)
{
auto iter = ManifestFieldTypes.find(key);
if (iter != ManifestFieldTypes.end())
{
return iter->second;
}
return YamlScalarType::String;
}
Json::Value YamlScalarNodeToJson(const YAML::Node& scalarNode, YamlScalarType scalarType)
{
if (scalarType == YamlScalarType::Int)
{
return Json::Value(scalarNode.as<int>());
}
else if (scalarType == YamlScalarType::Bool)
{
return Json::Value(scalarNode.as<bool>());
}
else
{
return Json::Value(scalarNode.as<std::string>());
}
}
Json::Value ManifestYamlNodeToJson(const YAML::Node& rootNode, YamlScalarType scalarType = YamlScalarType::String)
{
Json::Value result;
if (rootNode.IsNull())
{
result = Json::Value::nullSingleton();
}
else if (rootNode.IsMap())
{
for (auto const& keyValuePair : rootNode.Mapping())
{
// We only support string type as key in our manifest
auto key = keyValuePair.first.as<std::string>();
result[keyValuePair.first.as<std::string>()] = ManifestYamlNodeToJson(keyValuePair.second, GetManifestScalarValueType(key));
}
}
else if (rootNode.IsSequence())
{
for (auto const& value : rootNode.Sequence())
{
result.append(ManifestYamlNodeToJson(value, scalarType));
}
}
else if (rootNode.IsScalar())
{
result = YamlScalarNodeToJson(rootNode, scalarType);
}
else
{
THROW_HR(E_UNEXPECTED);
}
return result;
}
std::vector<ValidationError> ParseSchemaHeaderString(const YamlManifestInfo& manifestInfo, const ValidationError::Level& errorLevel, std::string& schemaHeaderUrlString)
{
std::vector<ValidationError> errors;
std::string schemaHeader = manifestInfo.DocumentSchemaHeader.SchemaHeader;
// Remove the leading '#' and any leading/trailing whitespaces
if (schemaHeader[0] == '#')
{
schemaHeader = schemaHeader.substr(1); // Remove the leading '#'
schemaHeader = Utility::Trim(schemaHeader); // Trim leading/trailing whitespaces
}
// Parse the schema header string as YAML string to get the schema header URL
try
{
auto root = YAML::Load(schemaHeader);
if (root.IsNull() || (!root.IsNull() && !root.IsDefined()))
{
errors.emplace_back(ValidationError::MessageContextValueLineLevelWithFile(ManifestError::InvalidSchemaHeader, "", schemaHeader, manifestInfo.DocumentSchemaHeader.Mark.line, manifestInfo.DocumentSchemaHeader.Mark.column, errorLevel, manifestInfo.FileName));
}
else
{
schemaHeaderUrlString = root[YAML::DocumentSchemaHeader::YamlLanguageServerKey].as<std::string>();
}
}
catch (const YAML::Exception&)
{
errors.emplace_back(ValidationError::MessageContextValueLineLevelWithFile(ManifestError::InvalidSchemaHeader, "", schemaHeader, manifestInfo.DocumentSchemaHeader.Mark.line, manifestInfo.DocumentSchemaHeader.Mark.column, errorLevel, manifestInfo.FileName));
}
catch (const std::exception&)
{
errors.emplace_back(ValidationError::MessageContextValueLineLevelWithFile(ManifestError::InvalidSchemaHeader, "", schemaHeader, manifestInfo.DocumentSchemaHeader.Mark.line, manifestInfo.DocumentSchemaHeader.Mark.column, errorLevel, manifestInfo.FileName));
}
return errors;
}
bool ParseSchemaHeaderUrl(const std::string& schemaHeaderValue, std::string& schemaType, std::string& schemaVersion)
{
// Use regex to match the pattern of @"winget-manifest\.(?<type>\w+)\.(?<version>[\d\.]+)\.schema\.json$"
std::regex schemaUrlPattern(R"(winget-manifest\.(\w+)\.([\d\.]+)\.schema\.json$)");
std::smatch match;
if (std::regex_search(schemaHeaderValue, match, schemaUrlPattern))
{
schemaType = match[1].str();
schemaVersion = match[2].str();
return true;
}
return false;
}
std::vector<ValidationError> ValidateSchemaHeaderType(const std::string& headerManifestType, const ManifestTypeEnum& expectedManifestType, const YamlManifestInfo& manifestInfo, ValidationError::Level errorLevel)
{
std::vector<ValidationError> errors;
ManifestTypeEnum actualManifestType = ConvertToManifestTypeEnum(headerManifestType);
size_t schemaHeaderTypeIndex = manifestInfo.DocumentSchemaHeader.SchemaHeader.find(headerManifestType) + 1;
if (actualManifestType != expectedManifestType)
{
errors.emplace_back(ValidationError::MessageContextValueLineLevelWithFile(ManifestError::SchemaHeaderManifestTypeMismatch, "", headerManifestType, manifestInfo.DocumentSchemaHeader.Mark.line, schemaHeaderTypeIndex, errorLevel, manifestInfo.FileName));
}
return errors;
}
std::vector<ValidationError> ValidateSchemaHeaderVersion(const std::string& headerManifestVersion, const ManifestVer& expectedManifestVersion, const YamlManifestInfo& manifestInfo, ValidationError::Level errorLevel)
{
std::vector<ValidationError> errors;
ManifestVer actualHeaderVersion(headerManifestVersion);
size_t schemaHeaderVersionIndex = manifestInfo.DocumentSchemaHeader.SchemaHeader.find(headerManifestVersion) + 1;
if (actualHeaderVersion != expectedManifestVersion)
{
errors.emplace_back(ValidationError::MessageContextValueLineLevelWithFile(ManifestError::SchemaHeaderManifestVersionMismatch, "", headerManifestVersion, manifestInfo.DocumentSchemaHeader.Mark.line, schemaHeaderVersionIndex, errorLevel, manifestInfo.FileName));
}
return errors;
}
bool IsValidSchemaHeaderUrl(const std::string& schemaHeaderUrlString, const YamlManifestInfo& manifestInfo, const ManifestVer& manifestVersion)
{
// Load the schema file to compare the schema header URL with the schema ID in the schema file
Json::Value schemaFile = LoadSchemaDoc(manifestVersion, manifestInfo.ManifestType);
if (schemaFile.isMember("$id"))
{
std::string schemaId = schemaFile["$id"].asString();
// Prefix schema ID with "schema=" to match the schema header URL pattern and compare it with the schema header URL
schemaId = "$schema=" + schemaId;
if (Utility::CaseInsensitiveEquals(schemaId, schemaHeaderUrlString))
{
return true;
}
}
return false;
}
ValidationError GetSchemaHeaderUrlPatternMismatchError(const std::string& schemaHeaderUrlString, const YamlManifestInfo& manifestInfo, const ValidationError::Level& errorLevel)
{
size_t schemaHeaderUrlIndex = manifestInfo.DocumentSchemaHeader.SchemaHeader.find(schemaHeaderUrlString) + 1;
return ValidationError::MessageContextValueLineLevelWithFile(ManifestError::SchemaHeaderUrlPatternMismatch, "", manifestInfo.DocumentSchemaHeader.SchemaHeader, manifestInfo.DocumentSchemaHeader.Mark.line, schemaHeaderUrlIndex, errorLevel, manifestInfo.FileName);
}
std::vector<ValidationError> ValidateSchemaHeaderUrl(const YamlManifestInfo& manifestInfo, const ManifestVer& manifestVersion, const ValidationError::Level& errorLevel)
{
std::vector<ValidationError> errors;
std::string schemaHeaderUrlString;
// Parse the schema header string to get the schema header URL
auto parserErrors = ParseSchemaHeaderString(manifestInfo, errorLevel, schemaHeaderUrlString);
std::move(parserErrors.begin(), parserErrors.end(), std::inserter(errors, errors.end()));
if (!errors.empty())
{
return errors;
}
std::string manifestTypeString;
std::string manifestVersionString;
// Parse the schema header URL to get the manifest type and version
if (ParseSchemaHeaderUrl(schemaHeaderUrlString, manifestTypeString, manifestVersionString))
{
auto headerManifestTypeErrors = ValidateSchemaHeaderType(manifestTypeString, manifestInfo.ManifestType, manifestInfo, errorLevel);
std::move(headerManifestTypeErrors.begin(), headerManifestTypeErrors.end(), std::inserter(errors, errors.end()));
auto headerManifestVersionErrors = ValidateSchemaHeaderVersion(manifestVersionString, manifestVersion, manifestInfo, errorLevel);
std::move(headerManifestVersionErrors.begin(), headerManifestVersionErrors.end(), std::inserter(errors, errors.end()));
// Finally, match the entire schema header URL with the schema ID in the schema file to ensure the URL domain matches the schema definition file.
if (!IsValidSchemaHeaderUrl(schemaHeaderUrlString, manifestInfo, manifestVersion))
{
errors.emplace_back(GetSchemaHeaderUrlPatternMismatchError(schemaHeaderUrlString, manifestInfo, errorLevel));
}
}
else
{
errors.emplace_back(GetSchemaHeaderUrlPatternMismatchError(schemaHeaderUrlString, manifestInfo, errorLevel));
}
return errors;
}
std::vector<ValidationError> ValidateYamlManifestSchemaHeader(const YamlManifestInfo& manifestInfo, const ManifestVer& manifestVersion, ValidationError::Level errorLevel)
{
std::vector<ValidationError> errors;
std::string schemaHeaderString;
if (manifestInfo.DocumentSchemaHeader.SchemaHeader.empty())
{
errors.emplace_back(ValidationError::MessageLevelWithFile(ManifestError::SchemaHeaderNotFound, errorLevel, manifestInfo.FileName));
return errors;
}
auto parserErrors = ValidateSchemaHeaderUrl(manifestInfo, manifestVersion, errorLevel);
std::move(parserErrors.begin(), parserErrors.end(), std::inserter(errors, errors.end()));
return errors;
}
}
Json::Value LoadSchemaDoc(const ManifestVer& manifestVersion, ManifestTypeEnum manifestType)
{
int idx = MANIFESTSCHEMA_NO_RESOURCE;
std::map<ManifestTypeEnum, int> resourceMap;
if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_12 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_12_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_12_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_12_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_12_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_12_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_10 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_10_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_10_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_10_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_10_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_10_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_9 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_9_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_9_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_9_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_9_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_9_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_7 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_7_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_7_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_7_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_7_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_7_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_6 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_6_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_6_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_6_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_6_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_6_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_5 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_5_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_5_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_5_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_5_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_5_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_4 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_4_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_4_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_4_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_4_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_4_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_2 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_2_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_2_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_2_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_2_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_2_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1_1 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_1_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_1_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_1_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_1_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_1_LOCALE },
};
}
else if (manifestVersion >= ManifestVer{ s_ManifestVersionV1 })
{
resourceMap = {
{ ManifestTypeEnum::Singleton, IDX_MANIFEST_SCHEMA_V1_SINGLETON },
{ ManifestTypeEnum::Version, IDX_MANIFEST_SCHEMA_V1_VERSION },
{ ManifestTypeEnum::Installer, IDX_MANIFEST_SCHEMA_V1_INSTALLER },
{ ManifestTypeEnum::DefaultLocale, IDX_MANIFEST_SCHEMA_V1_DEFAULTLOCALE },
{ ManifestTypeEnum::Locale, IDX_MANIFEST_SCHEMA_V1_LOCALE },
};
}
else
{
resourceMap = {
{ ManifestTypeEnum::Preview, IDX_MANIFEST_SCHEMA_PREVIEW },
};
}
auto iter = resourceMap.find(manifestType);
if (iter != resourceMap.end())
{
idx = iter->second;
}
else
{
THROW_HR(HRESULT_FROM_WIN32(ERROR_NOT_SUPPORTED));
}
std::string_view schemaStr = Resource::GetResourceAsString(idx, MANIFESTSCHEMA_RESOURCE_TYPE);
return JsonSchema::LoadSchemaDoc(schemaStr);
}
std::vector<ValidationError> ValidateAgainstSchema(const std::vector<YamlManifestInfo>& manifestList, const ManifestVer& manifestVersion)
{
std::vector<ValidationError> errors;
// A list of schema validator to avoid multiple loadings of same schema
std::map<ManifestTypeEnum, valijson::Schema> schemaList;
for (const auto& entry : manifestList)
{
if (entry.ManifestType == ManifestTypeEnum::Shadow)
{
// There's no schema for a shadow manifest.
continue;
}
if (schemaList.find(entry.ManifestType) == schemaList.end())
{
// Copy constructor of valijson::Schema was private
valijson::Schema& newSchema = schemaList.emplace(
std::piecewise_construct, std::make_tuple(entry.ManifestType), std::make_tuple()).first->second;
Json::Value schemaJson = LoadSchemaDoc(manifestVersion, entry.ManifestType);
JsonSchema::PopulateSchema(schemaJson, newSchema);
}
const auto& schema = schemaList.find(entry.ManifestType)->second;
Json::Value manifestJson = ManifestYamlNodeToJson(entry.Root);
valijson::ValidationResults results;
if (!JsonSchema::Validate(schema, manifestJson, results))
{
errors.emplace_back(ValidationError::MessageContextWithFile(ManifestError::SchemaError, JsonSchema::GetErrorStringFromResults(results), entry.FileName));
}
}
return errors;
}
std::vector<ValidationError> ValidateYamlManifestsSchemaHeader(const std::vector<YamlManifestInfo>& manifestList, const ManifestVer& manifestVersion, bool treatErrorAsWarning)
{
std::vector<ValidationError> errors;
ValidationError::Level errorLevel = treatErrorAsWarning ? ValidationError::Level::Warning : ValidationError::Level::Error;
// Read the manifest schema header and ensure it exists
for (const auto& entry : manifestList)
{
if (entry.ManifestType == ManifestTypeEnum::Shadow)
{
// There's no schema for a shadow manifest.
continue;
}
auto schemaHeaderErrors = ValidateYamlManifestSchemaHeader(entry, manifestVersion, errorLevel);
std::move(schemaHeaderErrors.begin(), schemaHeaderErrors.end(), std::inserter(errors, errors.end()));
}
return errors;
}
}