Agent Sessions: Background agents context menu

[bamurtaugh]

Ref https://github.com/microsoft/vscode-internalbacklog/issues/6527

• When I right-click on a background agent session, I see separate options for Archive vs Delete, but the inline archive action uses Delete as its tooltip. Should the inline archive action have a different tooltip (since Archive != Delete)?
  • 
  • 
• I see Apply Changes to Workspace even if my background session doesn't have any changes
  • Could we either hide this entry if a session doesn't have any changes, or provide a notification to a user that there are no changes to apply if they click it?
  • 

[bpasero]

This one is interesting: Delete here actually refers to the keyboard shortcut. You can press the Delete key on your keyboard to archive. I am not sure what to do here actually, we show keyboard shortcut names like this everywhere.

@mrleemurray what do you think?

[mrleemurray]

Can we remove the context menu delete option, then give the user to empty / permanently delete the archive contents (like the deleted folder in Outlook)?

[bpasero]

I am not sure that solves the issue actually because it still reads somewhat weird to have "Delete" right after "Archive".

[bamurtaugh]

@mrleemurray's suggestion to remove the context menu Delete option would've reduced my initial confusion, but I agree @bpasero that I may not have realized that Delete in the tooltip was referring to the keyboard shortcut rather than explaining the feature as deletion. Perhaps removing Delete from the context menu to start would've gotten me to focus on the keyboard shortcuts more at some point though and learn this, so removing it could be a good first step.

[bpasero]

But to clarify I think I want both Archive and Delete in the context menu, I see no reason why we would hide the one only because of this issue. I see agent sessions like emails I want to deal with and forcing me to first archive and then delete seems odd.

[bamurtaugh]

That makes sense. We can also see if we get user feedback here (about users' use and expectations around session archiving and deletion, if folks often use both, if folks understand the difference or need further differentiation, etc).

[cwebster-99]

I ran into this today and was quite confused having both options displayed and struggle to understand the difference.

[bpasero]

I hope this helps:

• Archive: hide the session from the UI but do not delete underlying resources, allows to always restore from archive
• Delete: the session is removed and cannot be restored, underlying resources are deleted and cleaned up

[cwebster-99]

Yeah that is super helpful! Perhaps these distinct options would become more clear if finding your archived chats was more discoverable. Should we be showing Archived chats by default since the archive option is a top level action in the chat card?