Support disabling AI features, PR feedback

Author: kycutler

src/vs/platform/browserElements/common/browserElements.ts

@@ -20,7 +20,19 @@ export interface IElementData {
  * Uses either the parent webview or browser view id to uniquely identify the target.
  */
 export interface IBrowserTargetLocator {
+	/**
+	 * Identifier of the parent webview hosting the target.
+	 *
+	 * Exactly one of {@link webviewId} or {@link browserViewId} should be provided.
+	 * Use this when the target is rendered inside a webview.
+	 */
 	readonly webviewId?: string;
+	/**
+	 * Identifier of the browser view hosting the target.
+	 *
+	 * Exactly one of {@link webviewId} or {@link browserViewId} should be provided.
+	 * Use this when the target is rendered inside a browser view rather than a webview.
+	 */
 	readonly browserViewId?: string;
 }
 

src/vs/platform/browserElements/electron-main/nativeBrowserElementsMainService.ts

@@ -40,7 +40,7 @@ export class NativeBrowserElementsMainService extends Disposable implements INat
 
 	/**
 	 * Find the webview target that matches the given locator.
-	 * Checks either parentWebviewOrigin or webContentsId depending on what's provided.
+	 * Checks either webviewId or browserViewId depending on what's provided.
 	 */
 	async findWebviewTarget(debuggers: Electron.Debugger, locator: IBrowserTargetLocator): Promise<string | undefined> {
 		const { targetInfos } = await debuggers.sendCommand('Target.getTargets');

src/vs/workbench/contrib/browserView/electron-browser/browserViewActions.ts

@@ -15,6 +15,7 @@ import { BrowserEditor, CONTEXT_BROWSER_CAN_GO_BACK, CONTEXT_BROWSER_CAN_GO_FORW
 import { BrowserViewUri } from '../../../../platform/browserView/common/browserViewUri.js';
 import { IBrowserViewWorkbenchService } from '../common/browserView.js';
 import { BrowserViewStorageScope } from '../../../../platform/browserView/common/browserView.js';
+import { ChatContextKeys } from '../../chat/common/actions/chatContextKeys.js';
 
 // Context key expression to check if browser editor is active
 const BROWSER_EDITOR_ACTIVE = ContextKeyExpr.equals('activeEditor', BrowserEditor.ID);
@@ -147,11 +148,13 @@ class SelectElementAction extends Action2 {
 			title: localize2('browser.selectElementAction', 'Add Element to Chat'),
 			icon: Codicon.inspect,
 			f1: true,
+			precondition: ChatContextKeys.enabled,
 			toggled: CONTEXT_BROWSER_ELEMENT_SELECTION_ACTIVE,
 			menu: {
 				id: MenuId.BrowserActionsToolbar,
 				group: 'actions',
 				order: 1,
+				when: ChatContextKeys.enabled
 			}
 		});
 	}

src/vs/workbench/contrib/chat/browser/attachments/simpleBrowserEditorOverlay.ts

@@ -399,7 +399,6 @@ class SimpleBrowserOverlayController {
 		this._store.add(autorun(r => {
 
 			const webviewId = activeIdObs.read(r);
-			widget.setActiveLocator(webviewId ? { webviewId } : undefined);
 
 			if (!webviewId) {
 				hide();