mcp: fix start all servers command (#286624)

* mcp: fix start all servers command

If user specified `undefined` as the `serverId`

```
await vscode.commands.executeCommand('workbench.mcp.startServer', undefined);
```

…it would be turned into `null` when passed through the command system
and was therefore not being treated as a wildcard.

Resolves #283959.

* mcp: fix start all servers command

Resolves #283959.

Previous implementation looked strictly for `undefined`, but the IPC layer
converts `undefined` to `null`. This meant that calling the command via IPC
like:

```
await vscode.commands.executeCommand('workbench.mcp.startServer', undefined);
```

was not working (while `vscode.commands.executeCommand('workbench.mcp.startServer')` was).

Instead of handling `null` as a value as well, use a specicial value of `*`
to indicate all servers should be started so the intent is clearer:

```
BEFORE: await vscode.commands.executeCommand('workbench.mcp.startServer');
AFTER : await vscode.commands.executeCommand('workbench.mcp.startServer', '*');
```

Additionally, add a `waitForLiveTools` parameter that blocks the command
from resolving until the server is downloaded, started, and tools are availble.

Without this, a static sleep or poll would be needed.

Author: rwoll

src/vs/workbench/contrib/mcp/browser/mcpCommands.ts

@@ -64,6 +64,7 @@ import { IMcpRegistry } from '../common/mcpRegistryTypes.js';
 import { HasInstalledMcpServersContext, IMcpSamplingService, IMcpServer, IMcpServerStartOpts, IMcpService, InstalledMcpServersViewId, LazyCollectionState, McpCapability, McpCollectionDefinition, McpConnectionState, McpDefinitionReference, mcpPromptPrefix, McpServerCacheState, McpStartServerInteraction } from '../common/mcpTypes.js';
 import { McpAddConfigurationCommand } from './mcpCommandsAddConfiguration.js';
 import { McpResourceQuickAccess, McpResourceQuickPick } from './mcpResourceQuickAccess.js';
+import { startServerAndWaitForLiveTools } from '../common/mcpTypesUtils.js';
 import './media/mcpServerAction.css';
 import { openPanelChatAndGetWidget } from './openPanelChatAndGetWidget.js';
 
@@ -821,13 +822,18 @@ export class StartServer extends Action2 {
 		});
 	}
 
-	async run(accessor: ServicesAccessor, serverId: string | undefined, opts?: IMcpServerStartOpts) {
+	async run(accessor: ServicesAccessor, serverId: string, opts?: IMcpServerStartOpts & { waitForLiveTools?: boolean }) {
 		let servers = accessor.get(IMcpService).servers.get();
-		if (serverId !== undefined) {
+		if (serverId !== '*') {
 			servers = servers.filter(s => s.definition.id === serverId);
 		}
 
-		await Promise.all(servers.map(s => s.start({ promptType: 'all-untrusted', ...opts })));
+		const startOpts: IMcpServerStartOpts = { promptType: 'all-untrusted', ...opts };
+		if (opts?.waitForLiveTools) {
+			await Promise.all(servers.map(s => startServerAndWaitForLiveTools(s, startOpts)));
+		} else {
+			await Promise.all(servers.map(s => s.start(startOpts)));
+		}
 	}
 }