Fix range error when creating new function app (#481)

Author: ejizba

src/templates/DotnetTemplateRetriever.ts

@@ -6,6 +6,7 @@
 import * as fse from 'fs-extra';
 import { ProjectRuntime } from '../constants';
 import { ext } from '../extensionVariables';
+import { localize } from '../localize';
 import { dotnetUtils } from '../utils/dotnetUtils';
 import { downloadFile } from '../utils/fs';
 import { cliFeedJsonResponse } from '../utils/getCliFeedJson';
@@ -80,7 +81,7 @@ export function getDotnetVerifiedTemplateIds(runtime: string): string[] {
             case ProjectRuntime.beta:
                 return `${id}.2.x`;
             default:
-                throw new RangeError();
+                throw new RangeError(localize('invalidRuntime', 'Invalid runtime "{0}".', runtime));
         }
     });
 }

src/tree/FunctionAppProvider.ts

@@ -68,22 +68,22 @@ export class FunctionAppProvider implements IChildProvider {
 
 async function getDefaultRuntime(actionContext: IActionContext): Promise<ProjectRuntime> {
     // Try to get VS Code setting for runtime (aka if they have a project open)
-    let runtime: ProjectRuntime | undefined = getFuncExtensionSetting(projectRuntimeSetting);
+    let runtime: string | undefined = getFuncExtensionSetting(projectRuntimeSetting);
     actionContext.properties.runtimeSource = 'VSCodeSetting';
 
-    if (runtime === undefined) {
+    if (!runtime) {
         // Try to get the runtime that matches their local func cli version
         runtime = await tryGetLocalRuntimeVersion();
         actionContext.properties.runtimeSource = 'LocalFuncCli';
     }
 
-    if (runtime === undefined) {
+    if (!runtime) {
         // Default to v1 if all else fails
         runtime = ProjectRuntime.one;
         actionContext.properties.runtimeSource = 'Backup';
     }
 
     actionContext.properties.projectRuntime = runtime;
 
-    return runtime;
+    return <ProjectRuntime>runtime;
 }

src/utils/getCliFeedJson.ts

@@ -7,6 +7,7 @@
 import request = require('request-promise');
 import { callWithTelemetryAndErrorHandling, IActionContext } from 'vscode-azureextensionui';
 import { ProjectRuntime } from '../constants';
+import { localize } from '../localize';
 
 const funcCliFeedUrl: string = 'https://aka.ms/V00v5v';
 const v1DefaultNodeVersion: string = '6.5.0';
@@ -51,7 +52,7 @@ export function getFeedRuntime(runtime: ProjectRuntime): string {
         case ProjectRuntime.one:
             return 'v1';
         default:
-            throw new RangeError();
+            throw new RangeError(localize('invalidRuntime', 'Invalid runtime "{0}".', runtime));
     }
 }