`@augments` JSDoc tag causes compilation error in generated declaration file

[dragomirtitian]

Steps to reproduce

Declaration file generated by typescript does not typecheck with TypeScript in API and language server

declare class Base {
}
declare const StateDependencies_base: typeof Base;
/**
 * The state dependencies is a record that holds all the injected dependencies
 * for the stores/state.
 *
 * @class StateDependencies
 * @augments {Base}
 */
export declare class StateDependencies extends StateDependencies_base {
}

export {};
 

Behavior with typescript@6.0

No error

Behavior with tsgo

In the api and language server we get:

JSDoc '@augments Base' does not match the 'extends StateDependencies_base' clause.  ts(8023)

[weswigham]

That @augments check must be much too strict. StateDependencies_base is, indeed, functionally identical to Base. Basically an alias.

Oh, ew, we're comparing raw identifier text equality in the grammar checker. We should move this check out of checkGrammarClassDeclarationHeritageClauses (it's a comment - how could this ever be a grammar error in the first place) and into checkClassLikeDeclaration, and use isTypeIdenticalTo on the augments type node and the heritage clause instead...

[jakebailey]

I don't even know why this is happening in .ts files at all?

[weswigham]

Also a good point! Honestly, I don't know why we're checking this at all! This is, AFAIK, a lint-consistency level error, at most.