Fixed a crash on computed property name when computing inlay hints (#2892)

Author: Andarist

internal/fourslash/tests/inlayHintsPropertyDeclarationComputedName1_test.go

@@ -0,0 +1,28 @@
+package fourslash_test
+
+import (
+	"testing"
+
+	"github.com/microsoft/typescript-go/internal/fourslash"
+	"github.com/microsoft/typescript-go/internal/ls/lsutil"
+	"github.com/microsoft/typescript-go/internal/testutil"
+)
+
+func TestInlayHintsPropertyDeclarationComputedName1(t *testing.T) {
+	t.Parallel()
+
+	defer testutil.RecoverAndFail(t, "Panic on fourslash test")
+	const content = `function foo() {
+  const sym = Symbol();
+  class C {
+    [sym] = 123;
+  }
+}`
+	f, done := fourslash.NewFourslash(t, nil /*capabilities*/, content)
+	defer done()
+	f.VerifyBaselineInlayHints(t, nil /*span*/, &lsutil.UserPreferences{
+		InlayHints: lsutil.InlayHintsPreferences{
+			IncludeInlayPropertyDeclarationTypeHints: true,
+		},
+	})
+}

internal/ls/inlay_hints.go

@@ -245,6 +245,7 @@ func (s *inlayHintState) visitVariableLikeDeclaration(decl *ast.VariableOrProper
 		hintText = b.String()
 	}
 	if !s.preferences.IncludeInlayVariableTypeHintsWhenTypeMatchesName &&
+		!ast.IsComputedPropertyName(decl.Name()) &&
 		stringutil.EquateStringCaseInsensitive(decl.Name().Text(), hintText) {
 		return
 	}

testdata/baselines/reference/fourslash/inlayHints/inlayHintsPropertyDeclarationComputedName1.baseline

@@ -0,0 +1,19 @@
+// === Inlay Hints ===
+    [sym] = 123;
+         ^
+{
+  "position": {
+    "line": 3,
+    "character": 9
+  },
+  "label": [
+    {
+      "value": ": "
+    },
+    {
+      "value": "number"
+    }
+  ],
+  "kind": 1,
+  "paddingLeft": true
+}