[rush] Allow custom commands with pass-through parameters

[Faithfinder]

I'm trying to integrate knip in our rush repo, and while it's mostly going fine, the custom command I'm using to invoke it is just knip. I would like to be able to pass in any of knip's CLI arguments to it when I invoke, and listing them manually seems like a crazy exercise.

[iclanton]

It'd be possible to add an option in command-line.json to allow "remainder" parameters to be passed to a bulk process. ts-command-line supports this, but it isn't exposed in Rush.

Would you be interested in adding this feature?

[Faithfinder]

Meh, maybe. I have very little time/energy to spend on open source, but inspiration could struck and this sounds like it wouldn't take more than an hour. Can you point to a good file to start with for me or whoever takes this?

[Faithfinder]

(BTW, the command is global, not bulk, but I imagine it can be implemented and useful for both)

[cubabit]

@Faithfinder can you please share your config setup to integrate knip with rush? Did you use a rush command? Did you have a single knip config file?

[Faithfinder]

@Faithfinder can you please share your config setup to integrate knip with rush? Did you use a rush command? Did you have a single knip config file?

Single file, yes, but I can't share the config as I'm not in that job anymore. Wasn't anything tricky, just ignore rush's config folders and expand entry files in individual projects as needed.

[delarre-reve]

@iclanton could you advise where to make such changes? I'd be happy to file a PR for this but need a bit of guidance as to where to look at this integration.

[iclanton]

Our CLI parsing library (@rushstack/ts-command-line) already has support for getting the remaining values, so on the Rush side, it'll involve adding option(s) to command-line.json (look for things that use command-line.schema.json) and then plumbing them through to the command objects that get created when a Rush process boots up.

[sdotson]

Hi. Also interested in this feature. Could you walk us through what the main classes/methods are that process this proposed AllowRemainderArguments property in the command-line.schema.json? I'm finding it challenging to reason about how custom commands arguments are parsed and executed.

On the other side of this, I see that @rush/ts-command-line has this defineCommandLineRemainder method. So I imagine it's somehow filling in the middle steps between defining a flag in command-line.schema.json to this method and making sure no erorrs are thrown when folks start adding -- and their additional passthrough parameters?

Happy to collaborate or push this through, I think I just need a little assistance.

[sdotson]

I've made an attempt: #5409