From bf7f138f49bddcd25a63cc42c75cdbc067dc71d2 Mon Sep 17 00:00:00 2001 From: vineethkuttan <66076509+vineethkuttan@users.noreply.github.com> Date: Mon, 9 Mar 2026 15:35:56 +0530 Subject: [PATCH 1/6] Try fixing #13599 --- .ado/jobs/cli-init-windows.yml | 18 +++++++++--------- .ado/jobs/playground.yml | 2 -- ...rosoft.ReactNative.Composition.CppLib.props | 10 ++++++++++ ...icrosoft.ReactNative.Cpp.Dependencies.props | 9 +++++++++ .../Microsoft.ReactNative.Uwp.CppLib.props | 10 ++++++++++ 5 files changed, 38 insertions(+), 11 deletions(-) diff --git a/.ado/jobs/cli-init-windows.yml b/.ado/jobs/cli-init-windows.yml index c0d060d9162..f124b154578 100644 --- a/.ado/jobs/cli-init-windows.yml +++ b/.ado/jobs/cli-init-windows.yml @@ -39,19 +39,19 @@ parameters: template: cpp-lib configuration: Release platform: x64 - additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: useNuGet: true - Name: FabricLibX86Debug template: cpp-lib configuration: Debug platform: x86 - additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: useNuGet: true - Name: FabricLibArm64Release template: cpp-lib configuration: Release platform: ARM64 - additionalRunArguments: --no-deploy --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: --no-deploy useNuGet: true - BuildEnvironment: SecurePullRequest Matrix: @@ -107,37 +107,37 @@ parameters: template: cpp-lib configuration: Debug platform: x64 - additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: useNuGet: true - Name: FabricLibX64Release template: cpp-lib configuration: Release platform: x64 - additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: useNuGet: true - Name: FabricLibX86Debug template: cpp-lib configuration: Debug platform: x86 - additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: useNuGet: true - Name: FabricLibX86Release template: cpp-lib configuration: Release platform: x86 - additionalRunArguments: --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: useNuGet: true - Name: FabricLibArm64Debug template: cpp-lib configuration: Debug platform: ARM64 - additionalRunArguments: --no-deploy --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: --no-deploy useNuGet: true - Name: FabricLibArm64Release template: cpp-lib configuration: Release platform: ARM64 - additionalRunArguments: --no-deploy --singleproc # --singleproc required to workaround issue #13599 + additionalRunArguments: --no-deploy useNuGet: true jobs: - ${{ each config in parameters.buildMatrix }}: diff --git a/.ado/jobs/playground.yml b/.ado/jobs/playground.yml index 7da2ba11f6f..187fb07ef9b 100644 --- a/.ado/jobs/playground.yml +++ b/.ado/jobs/playground.yml @@ -110,8 +110,6 @@ jobs: msbuildArgs: /p:PackageCertificateKeyFile=$(Build.SourcesDirectory)\EncodedKey.pfx /p:PackageCertificatePassword=${{ parameters.certificatePassword }} - ${{if eq(matrix.SolutionFile, 'Playground-Composition.sln')}}: - parallelBuild: false # required to workaround issue #13599 - ${{if and(false, endsWith(matrix.Name, 'Universal'), eq(matrix.BuildConfiguration, 'Debug')) }}: # Disabled as debugging doesn't work,remove false after issue is resolved, see https://github.com/microsoft/react-native-windows/issues/13543 # Execute debug feature tests (skip this step for the Win32 Playground app and for release builds) diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props index ba683e758fd..66698307744 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props @@ -13,6 +13,16 @@ + + + true + + diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props index f2c34cc60eb..706f2ad5bc6 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props @@ -12,6 +12,15 @@ 2.0.230706.1 + + false diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props index 0b4020a1ad8..2619ee0766b 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props @@ -14,6 +14,16 @@ + + + true + + From de4d6d3bb56227797c36cef640a63d8653273f97 Mon Sep 17 00:00:00 2001 From: vineethkuttan <66076509+vineethkuttan@users.noreply.github.com> Date: Mon, 9 Mar 2026 15:36:57 +0530 Subject: [PATCH 2/6] Change files --- ...ative-windows-11d17e38-1d0e-4ba7-b807-02f7bf4e0da9.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/react-native-windows-11d17e38-1d0e-4ba7-b807-02f7bf4e0da9.json diff --git a/change/react-native-windows-11d17e38-1d0e-4ba7-b807-02f7bf4e0da9.json b/change/react-native-windows-11d17e38-1d0e-4ba7-b807-02f7bf4e0da9.json new file mode 100644 index 00000000000..f8245f7fe7b --- /dev/null +++ b/change/react-native-windows-11d17e38-1d0e-4ba7-b807-02f7bf4e0da9.json @@ -0,0 +1,7 @@ +{ + "type": "prerelease", + "comment": "Try fixing the circular dependency error", + "packageName": "react-native-windows", + "email": "66076509+vineethkuttan@users.noreply.github.com", + "dependentChangeType": "patch" +} From 601174886ea0ffb94e70648785e71a8892518225 Mon Sep 17 00:00:00 2001 From: vineethkuttan <66076509+vineethkuttan@users.noreply.github.com> Date: Tue, 10 Mar 2026 09:51:09 +0530 Subject: [PATCH 3/6] fix by looking in winget-cli - https://github.com/microsoft/winget-cli/pull/5932 --- .../Microsoft.ReactNative.Composition.CppApp.props | 10 ++++++++++ .../Microsoft.ReactNative.Composition.CppLib.props | 8 ++++---- .../Microsoft.ReactNative.Cpp.Dependencies.props | 9 --------- .../External/Microsoft.ReactNative.Uwp.CppApp.props | 10 ++++++++++ .../External/Microsoft.ReactNative.Uwp.CppLib.props | 8 ++++---- 5 files changed, 28 insertions(+), 17 deletions(-) diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props index ab780acbf7c..eea7fa0ea17 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props @@ -18,6 +18,16 @@ + + + false + + diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props index 66698307744..8c64b20a240 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppLib.props @@ -14,10 +14,10 @@ true diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props index 706f2ad5bc6..f2c34cc60eb 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Cpp.Dependencies.props @@ -12,15 +12,6 @@ 2.0.230706.1 - - false diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props index 404f46ced54..574f60ac3e0 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props @@ -18,6 +18,16 @@ + + + false + + diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props index 2619ee0766b..acac08e6633 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppLib.props @@ -15,10 +15,10 @@ true From 6019969b6011a859266d28a8e74eaef5fa53cc2a Mon Sep 17 00:00:00 2001 From: vineethkuttan <66076509+vineethkuttan@users.noreply.github.com> Date: Tue, 10 Mar 2026 13:37:41 +0530 Subject: [PATCH 4/6] Make changes in MyApp and revert changes in the prop --- .../Microsoft.ReactNative.Composition.CppApp.props | 10 ---------- .../External/Microsoft.ReactNative.Uwp.CppApp.props | 10 ---------- vnext/templates/cpp-app/windows/MyApp/MyApp.vcxproj | 2 ++ 3 files changed, 2 insertions(+), 20 deletions(-) diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props index eea7fa0ea17..ab780acbf7c 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Composition.CppApp.props @@ -18,16 +18,6 @@ - - - false - - diff --git a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props index 574f60ac3e0..404f46ced54 100644 --- a/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props +++ b/vnext/PropertySheets/External/Microsoft.ReactNative.Uwp.CppApp.props @@ -18,16 +18,6 @@ - - - false - - diff --git a/vnext/templates/cpp-app/windows/MyApp/MyApp.vcxproj b/vnext/templates/cpp-app/windows/MyApp/MyApp.vcxproj index 399bdd213b0..e799c9d8fbd 100644 --- a/vnext/templates/cpp-app/windows/MyApp/MyApp.vcxproj +++ b/vnext/templates/cpp-app/windows/MyApp/MyApp.vcxproj @@ -4,6 +4,8 @@ true + + false true {{ projectGuidUpper }} {{ name }} From 7d89b0466e5df912446f4c118aa714843999ec60 Mon Sep 17 00:00:00 2001 From: vineethkuttan <66076509+vineethkuttan@users.noreply.github.com> Date: Tue, 10 Mar 2026 14:25:35 +0530 Subject: [PATCH 5/6] Add Force Synchronous PDB Write --- .../playground-composition/Playground-Composition.vcxproj | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/playground/windows/playground-composition/Playground-Composition.vcxproj b/packages/playground/windows/playground-composition/Playground-Composition.vcxproj index 741b3367c7e..0deea107e69 100644 --- a/packages/playground/windows/playground-composition/Playground-Composition.vcxproj +++ b/packages/playground/windows/playground-composition/Playground-Composition.vcxproj @@ -82,7 +82,7 @@ $(IntDir)pch.pch Level4 true - %(AdditionalOptions) /bigobj + %(AdditionalOptions) /bigobj /FS 4453;28204 From 1a7444dd79b0d09217d21c26953b743759699d85 Mon Sep 17 00:00:00 2001 From: vineethkuttan <66076509+vineethkuttan@users.noreply.github.com> Date: Wed, 11 Mar 2026 12:11:16 +0530 Subject: [PATCH 6/6] Remove the direct Build.0/Deploy.0 entries for the vcxproj --- .../playground/windows/playground-composition.sln | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/packages/playground/windows/playground-composition.sln b/packages/playground/windows/playground-composition.sln index 9622d6c9fe4..75a2659521f 100644 --- a/packages/playground/windows/playground-composition.sln +++ b/packages/playground/windows/playground-composition.sln @@ -72,23 +72,11 @@ EndProject {10DADE6A-A98D-45D4-9CCB-0C6E82227CDC}.Release|ARM64.Build.0 = Release|ARM64 {10DADE6A-A98D-45D4-9CCB-0C6E82227CDC}.Release|ARM64.Deploy.0 = Release|ARM64 {F54A991F-5535-43DF-AE79-85821E001675}.Debug|x64.ActiveCfg = Debug|x64 - {F54A991F-5535-43DF-AE79-85821E001675}.Debug|x64.Build.0 = Debug|x64 - {F54A991F-5535-43DF-AE79-85821E001675}.Debug|x64.Deploy.0 = Debug|x64 {F54A991F-5535-43DF-AE79-85821E001675}.Debug|x86.ActiveCfg = Debug|Win32 - {F54A991F-5535-43DF-AE79-85821E001675}.Debug|x86.Build.0 = Debug|Win32 - {F54A991F-5535-43DF-AE79-85821E001675}.Debug|x86.Deploy.0 = Debug|Win32 {F54A991F-5535-43DF-AE79-85821E001675}.Debug|ARM64.ActiveCfg = Debug|ARM64 - {F54A991F-5535-43DF-AE79-85821E001675}.Debug|ARM64.Build.0 = Debug|ARM64 - {F54A991F-5535-43DF-AE79-85821E001675}.Debug|ARM64.Deploy.0 = Debug|ARM64 {F54A991F-5535-43DF-AE79-85821E001675}.Release|x64.ActiveCfg = Release|x64 - {F54A991F-5535-43DF-AE79-85821E001675}.Release|x64.Build.0 = Release|x64 - {F54A991F-5535-43DF-AE79-85821E001675}.Release|x64.Deploy.0 = Release|x64 {F54A991F-5535-43DF-AE79-85821E001675}.Release|x86.ActiveCfg = Release|Win32 - {F54A991F-5535-43DF-AE79-85821E001675}.Release|x86.Build.0 = Release|Win32 - {F54A991F-5535-43DF-AE79-85821E001675}.Release|x86.Deploy.0 = Release|Win32 {F54A991F-5535-43DF-AE79-85821E001675}.Release|ARM64.ActiveCfg = Release|ARM64 - {F54A991F-5535-43DF-AE79-85821E001675}.Release|ARM64.Build.0 = Release|ARM64 - {F54A991F-5535-43DF-AE79-85821E001675}.Release|ARM64.Deploy.0 = Release|ARM64 {A990658C-CE31-4BCC-976F-0FC6B1AF693D}.Debug|ARM64.ActiveCfg = Debug|ARM64 {A990658C-CE31-4BCC-976F-0FC6B1AF693D}.Debug|ARM64.Build.0 = Debug|ARM64 {A990658C-CE31-4BCC-976F-0FC6B1AF693D}.Debug|x64.ActiveCfg = Debug|x64