Skip to content

Commit fe8018b

Browse files
authored
fix: declare support for 0.84 (#2634)
1 parent ed766c7 commit fe8018b

5 files changed

Lines changed: 14 additions & 15 deletions

File tree

packages/app/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -99,7 +99,7 @@
9999
"@callstack/react-native-visionos": "0.76 - 0.79",
100100
"@expo/config-plugins": ">=5.0",
101101
"react": "18.2 - 19.2",
102-
"react-native": "0.76 - 0.83 || >=0.83.0-0 <0.84.0",
102+
"react-native": "0.76 - 0.84 || >=0.84.0-0 <0.85.0",
103103
"react-native-macos": "^0.0.0-0 || 0.76 - 0.81",
104104
"react-native-windows": "^0.0.0-0 || 0.76 - 0.81"
105105
},

packages/app/scripts/testing/test-apple.mts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ export const getIOSSimulatorName = memo(() => {
3232
"An error occurred while trying to evaluate 'wdio.config.mjs'"
3333
);
3434
}
35-
return stdout.trim();
35+
return `'${stdout.trim()}'`;
3636
});
3737

3838
/**

packages/app/scripts/testing/test-e2e.mts

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,16 @@ import { spawnSync } from "node:child_process";
66
import { Socket } from "node:net";
77
import { isMain } from "../helpers.js";
88

9+
export const DEFAULT_SPAWN_OPTIONS = {
10+
stdio: "inherit",
11+
shell: true, // Yarn won't be able to find commands otherwise
12+
} as const;
13+
914
/**
1015
* Invokes a shell command with optional arguments.
1116
*/
1217
export function $(command: string, ...args: string[]) {
13-
const { status } = spawnSync(command, args, {
14-
stdio: "inherit",
15-
shell: process.platform === "win32",
16-
});
18+
const { status } = spawnSync(command, args, DEFAULT_SPAWN_OPTIONS);
1719
if (status !== 0) {
1820
throw new Error(
1921
`An error occurred while executing: ${command} ${args.join(" ")}`

packages/app/scripts/testing/test-matrix.mts

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import type { BuildConfig, TargetPlatform } from "../types.js";
1313
import { green, red, yellow } from "../utils/colors.mjs";
1414
import { rm_r } from "../utils/filesystem.mjs";
1515
import { getIOSSimulatorName, installPods } from "./test-apple.mts";
16-
import { $, $$, test } from "./test-e2e.mts";
16+
import { $, $$, DEFAULT_SPAWN_OPTIONS, test } from "./test-e2e.mts";
1717

1818
type PlatformConfig = {
1919
name: string;
@@ -364,8 +364,8 @@ if (platforms.length === 0) {
364364
.then(() => {
365365
showBanner("Initialize new app");
366366
$(
367-
PACKAGE_MANAGER,
368-
"init-test-app",
367+
process.argv0,
368+
"../scripts/init.mjs",
369369
"--destination",
370370
"template-example",
371371
"--name",
@@ -379,7 +379,7 @@ if (platforms.length === 0) {
379379
.then(() => {
380380
showBanner("Reconfigure existing app");
381381
const args = [
382-
"configure-test-app",
382+
"../scripts/configure.mjs",
383383
"-p",
384384
"android",
385385
"-p",
@@ -391,10 +391,7 @@ if (platforms.length === 0) {
391391
"-p",
392392
"windows",
393393
];
394-
const { status } = spawnSync(PACKAGE_MANAGER, args, {
395-
stdio: "inherit",
396-
shell: process.platform === "win32",
397-
});
394+
const { status } = spawnSync(process.argv0, args, DEFAULT_SPAWN_OPTIONS);
398395
if (status !== 1) {
399396
throw new Error("Expected an error");
400397
}

yarn.lock

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12262,7 +12262,7 @@ __metadata:
1226212262
"@callstack/react-native-visionos": 0.76 - 0.79
1226312263
"@expo/config-plugins": ">=5.0"
1226412264
react: 18.2 - 19.2
12265-
react-native: 0.76 - 0.83 || >=0.83.0-0 <0.84.0
12265+
react-native: 0.76 - 0.84 || >=0.84.0-0 <0.85.0
1226612266
react-native-macos: ^0.0.0-0 || 0.76 - 0.81
1226712267
react-native-windows: ^0.0.0-0 || 0.76 - 0.81
1226812268
peerDependenciesMeta:

0 commit comments

Comments
 (0)