Skip to content

Commit 32cb239

Browse files
author
Manish Ranjan Mahanta
committed
Address Review Comments
1 parent ae98597 commit 32cb239

2 files changed

Lines changed: 10 additions & 1 deletion

File tree

internal/uvm/create.go

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -189,6 +189,15 @@ func verifyOptions(_ context.Context, options interface{}) error {
189189
return errors.New("resource partition ID and CPU group ID cannot be set at the same time")
190190
}
191191
}
192+
if runtime.GOARCH == "arm64" {
193+
// ARM64 specific checks for currently unsupported features. These can be removed when the features are supported on ARM64.
194+
if opts.VPMemDeviceCount > 0 {
195+
return errors.New("VPMem devices are not supported on ARM64")
196+
}
197+
if opts.KernelDirect {
198+
return errors.New("KernelDirectBoot is not supported on ARM64")
199+
}
200+
}
192201
case *OptionsWCOW:
193202
if opts.EnableDeferredCommit && !opts.AllowOvercommit {
194203
return errors.New("EnableDeferredCommit is not supported on physically backed VMs")

internal/uvm/create_lcow.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -846,7 +846,7 @@ func makeLCOWDoc(ctx context.Context, opts *OptionsLCOW, uvm *UtilityVM) (_ *hcs
846846
kernelArgs += " " + opts.KernelBootOptions
847847
}
848848

849-
if runtime.GOARCH != "arm64" && !opts.VPCIEnabled {
849+
if !opts.VPCIEnabled {
850850
kernelArgs += ` pci=off`
851851
}
852852

0 commit comments

Comments
 (0)