From d7969426d8e90b8121ef76cb264dbc7e118ae47f Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Thu, 12 Feb 2026 12:27:51 -0800 Subject: [PATCH 1/5] Update CI --- .github/workflows/ci.yml | 38 ++++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index b957698..0620c93 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -45,15 +45,14 @@ jobs: run: | cmake -B Build -G Xcode -DARCANA_TESTS=OFF - # Commented out until tests are re-enabled - # - name: Build - # run: | - # cmake --build Build --config ${{ matrix.config }} - # - # - name: Test - # working-directory: Build - # run: | - # ctest -C ${{ matrix.config }} --output-on-failure --verbose + - name: Build + run: | + cmake --build Build --config ${{ matrix.config }} + + - name: Test + working-directory: Build + run: | + ctest -C ${{ matrix.config }} --output-on-failure --verbose ios: name: iOS @@ -75,6 +74,10 @@ jobs: -DCMAKE_IOS_INSTALL_COMBINED=YES \ -DARCANA_TESTS=OFF + - name: Build + run: | + cmake --build Build --config ${{ matrix.config }} + linux: name: Linux runs-on: ubuntu-latest @@ -106,12 +109,11 @@ jobs: -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} \ -DARCANA_TESTS=OFF - # Commented out until tests are re-enabled - # - name: Build - # run: | - # cmake --build Build --config ${{ matrix.config }} - # - # - name: Test - # working-directory: Build - # run: | - # ctest -C ${{ matrix.config }} --output-on-failure --verbose + - name: Build + run: | + cmake --build Build --config ${{ matrix.config }} + + - name: Test + working-directory: Build + run: | + ctest -C ${{ matrix.config }} --output-on-failure --verbose From 4daaa2936d307cfbaf0571ef853b2e9acede8938 Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Thu, 12 Feb 2026 12:32:52 -0800 Subject: [PATCH 2/5] Enable tests for macOS and Linux --- .github/workflows/ci.yml | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 0620c93..44b154a 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -43,7 +43,7 @@ jobs: - name: Configure CMake run: | - cmake -B Build -G Xcode -DARCANA_TESTS=OFF + cmake -B Build -G Xcode - name: Build run: | @@ -106,8 +106,7 @@ jobs: cmake -B Build \ -DCMAKE_BUILD_TYPE=${{ matrix.config }} \ -DCMAKE_C_COMPILER=${{ matrix.cc }} \ - -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} \ - -DARCANA_TESTS=OFF + -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} - name: Build run: | From baa6fa36cf0d8cb2e2f097f33575df6b679f1ae2 Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Thu, 12 Feb 2026 12:43:28 -0800 Subject: [PATCH 3/5] Fixes --- .github/workflows/ci.yml | 67 +++++++++++++++++++++++----------------- 1 file changed, 38 insertions(+), 29 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 44b154a..97b8b4b 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -20,16 +20,16 @@ jobs: - name: Configure CMake run: | - cmake -B Build -A ${{ matrix.arch }} + cmake -B Build -A ${{matrix.arch}} - name: Build run: | - cmake --build Build --config ${{ matrix.config }} + cmake --build Build --config ${{matrix.config}} - name: Test working-directory: Build run: | - ctest -C ${{ matrix.config }} --output-on-failure --verbose + ctest -C ${{matrix.config}} --output-on-failure --verbose macos: name: macOS @@ -41,18 +41,19 @@ jobs: steps: - uses: actions/checkout@v4 + # Tests are disabled until we can fix the build errors. - name: Configure CMake run: | - cmake -B Build -G Xcode + cmake -B Build -G Xcode -D ARCANA_TESTS=OFF - name: Build run: | - cmake --build Build --config ${{ matrix.config }} + cmake --build Build --config ${{matrix.config}} - - name: Test - working-directory: Build - run: | - ctest -C ${{ matrix.config }} --output-on-failure --verbose + # - name: Test + # working-directory: Build + # run: | + # ctest -C ${{matrix.config}} --output-on-failure --verbose ios: name: iOS @@ -65,18 +66,24 @@ jobs: steps: - uses: actions/checkout@v4 + # Tests are disabled until we can fix the build errors and figure out how to run them on the simulator. - name: Configure CMake for iOS run: | cmake -B Build -G Xcode \ - -DCMAKE_SYSTEM_NAME=iOS \ - -DCMAKE_OSX_DEPLOYMENT_TARGET=12.0 \ - -DCMAKE_XCODE_ATTRIBUTE_ONLY_ACTIVE_ARCH=NO \ - -DCMAKE_IOS_INSTALL_COMBINED=YES \ - -DARCANA_TESTS=OFF + -D CMAKE_SYSTEM_NAME=iOS \ + -D CMAKE_OSX_DEPLOYMENT_TARGET=12.0 \ + -D CMAKE_XCODE_ATTRIBUTE_ONLY_ACTIVE_ARCH=NO \ + -D CMAKE_IOS_INSTALL_COMBINED=YES \ + -D ARCANA_TESTS=OFF - name: Build run: | - cmake --build Build --config ${{ matrix.config }} + cmake --build Build --config ${{matrix.config}} + + # - name: Test + # working-directory: Build + # run: | + # ctest -C ${{matrix.config}} --output-on-failure --verbose linux: name: Linux @@ -84,14 +91,14 @@ jobs: strategy: matrix: config: [Debug, Release] - compiler: [gcc-11, clang-14] + compiler: [gcc-11, clang-12] include: - compiler: gcc-11 cc: gcc-11 cxx: g++-11 - - compiler: clang-14 - cc: clang-14 - cxx: clang++-14 + - compiler: clang-12 + cc: clang-12 + cxx: clang++-12 steps: - uses: actions/checkout@v4 @@ -99,20 +106,22 @@ jobs: - name: Install dependencies run: | sudo apt-get update - sudo apt-get install -y ${{ matrix.cc }} ${{ matrix.cxx }} + sudo apt-get install -y ${{matrix.cc }} ${{ matrix.cxx}} + # Tests are disabled until we can fix the build errors. - name: Configure CMake run: | cmake -B Build \ - -DCMAKE_BUILD_TYPE=${{ matrix.config }} \ - -DCMAKE_C_COMPILER=${{ matrix.cc }} \ - -DCMAKE_CXX_COMPILER=${{ matrix.cxx }} + -D CMAKE_BUILD_TYPE=${{matrix.config}} \ + -D CMAKE_C_COMPILER=${{matrix.cc}} \ + -D CMAKE_CXX_COMPILER=${{matrix.cxx}} \ + -D ARCANA_TESTS=OFF - name: Build run: | - cmake --build Build --config ${{ matrix.config }} - - - name: Test - working-directory: Build - run: | - ctest -C ${{ matrix.config }} --output-on-failure --verbose + cmake --build Build --config ${{matrix.config}} + + # - name: Test + # working-directory: Build + # run: | + # ctest -C ${{matrix.config}} --output-on-failure --verbose From 38a05cf4ac13ec13a32b65d4b549f912fb2276d6 Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Thu, 12 Feb 2026 12:45:59 -0800 Subject: [PATCH 4/5] More fixes --- .github/workflows/ci.yml | 6 +++--- README.md | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 97b8b4b..4db8768 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -96,9 +96,9 @@ jobs: - compiler: gcc-11 cc: gcc-11 cxx: g++-11 - - compiler: clang-12 - cc: clang-12 - cxx: clang++-12 + - compiler: clang-14 + cc: clang-14 + cxx: clang++-14 steps: - uses: actions/checkout@v4 diff --git a/README.md b/README.md index 3045a5b..9a9a693 100644 --- a/README.md +++ b/README.md @@ -13,7 +13,7 @@ You can learn more about API usage in the [arcana.cpp documentation](Source/Arca ### Prerequisites - CMake 3.15 or higher -- A C++20 compatible compiler (Visual Studio 2022+, GCC 11+, or Clang 12+) +- A C++20 compatible compiler (Visual Studio 2022+, GCC 11+, or Clang 14+) ### Building with CMake From d83bbb4d2a0e7e61c4a7d7605ce328aef1106fdc Mon Sep 17 00:00:00 2001 From: Gary Hsu Date: Thu, 12 Feb 2026 12:48:03 -0800 Subject: [PATCH 5/5] Ugh --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4db8768..98c7d7e 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -91,7 +91,7 @@ jobs: strategy: matrix: config: [Debug, Release] - compiler: [gcc-11, clang-12] + compiler: [gcc-11, clang-14] include: - compiler: gcc-11 cc: gcc-11