From 1566d2aa4885e2b2d46de1a01adc2230476cd03f Mon Sep 17 00:00:00 2001
From: "Alex Lam (APPX)" <alexlam@ntdev.microsoft.com>
Date: Mon, 23 Mar 2026 17:09:58 -0700
Subject: [PATCH] Disable VS sideloading telemetry DLLs to fix BinSkim BA2022

Setting AppxLogTelemetryFromSideloadingScript to false prevents VS's
MSBuild AppxPackage targets from copying SHA-1 signed telemetry DLLs
(Microsoft.Diagnostics.Tracing.EventSource.dll, etc.) into sample app
packages. These DLLs fail BinSkim BA2022 (SignSecurely).

The telemetry DLLs are not needed for sample app functionality - they
are only used for VS sideloading telemetry collection.

Fixes: https://dev.azure.com/microsoft/OS/_workitems/edit/57941542

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
---
 Samples/Directory.Build.props | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Samples/Directory.Build.props b/Samples/Directory.Build.props
index ac71b5d40..c3c210c88 100644
--- a/Samples/Directory.Build.props
+++ b/Samples/Directory.Build.props
@@ -1,5 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
 <Project ToolsVersion="14.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
+  <!-- Prevent VS from binplacing telemetry DLLs that fail BinSkim BA2022 (SignSecurely) -->
+  <PropertyGroup>
+    <AppxLogTelemetryFromSideloadingScript>false</AppxLogTelemetryFromSideloadingScript>
+  </PropertyGroup>
+
   <ItemDefinitionGroup>
     <ClCompile>
       <AdditionalOptions>%(AdditionalOptions) /Qspectre</AdditionalOptions>