Skip to content

Testing changes in playground doesn't work #1230

@krzysdz

Description

@krzysdz

When a PR to DefinitelyTyped is opened, the mergebot posts a comment You can test the changes of this PR in the Playground. When the link to playground is opened and user agrees to install the playground-dt-review plugin, the plugin makes a request to https://dtmergebot.azurewebsites.net/api/Playground-Info?number=${prNum}&code=<something>. This request fails, because dtmergebot.azurewebsites.net does not exist. There is a PR (orta/playground-dt-review#6) to change the URL to dtmergebot2, but it also doesn't exist.

According to the configuration, up-to-date domain is dtmergebot3.azurewebsites.net, but if I modify the plugin code and change the domain, server responds with 403 Ip Forbidden.

Could you either fix the API access (and somehow get @orta to update the plugin)? The alternative is removing entirely this broken functionality and the message from mergebot:

if (!info.tooManyFiles) {
display(``, `You can test the changes of this PR [in the Playground](${urls.playground(info.pr_number)}).`);
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions